Re: [PATCH] XFS: Check for valid transaction headers in recovery

[Lachlan McIlroy <lachlan@sgi.com>]

Looks fine now Dave.

Dave Chinner wrote:
> On Tue, Sep 23, 2008 at 10:07:56PM -0500, Eric Sandeen wrote:
>> Dave Chinner wrote:
>>> When we are about to add a new item to a transaction in recovery,
>>> we need to check that it is valid first. Current we just assert
>>> that header magic number matches, but in production systems
>>> that is not done add a corrupted transaction to the list to be
>>> processed. This results in a kernel oops later when processing the
>>> corrupted transaction.
>>>
>>> Instead, if we detect a corrupted transaction, abort recovery and
>>> leave the user to clean up the mess that has occurred.
>>>
>>> Signed-off-by: Dave Chinner <david@fromorbit.com>
>> Seems fine to me (I guess you tried the provided corrupt image?)
> 
> Yes, I tried to mount it.
> 
>> but the
>> commit message could be made a bit more ... English ;)
> 
> Right. Updated patch (description) below ;)
> 
> Cheers,
> 
> Dave.