From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] fix remount rw with unrecognized options
Date: Sun, 12 Oct 2008 17:21:44 -0500 [thread overview]
Message-ID: <48F27878.7050303@sandeen.net> (raw)
In-Reply-To: <20081012222032.GA19748@lst.de>
Christoph Hellwig wrote:
> On Sun, Oct 12, 2008 at 05:19:51PM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>>> When we skip unrecognized options in xfs_fs_remount we should just break
>>> out of the switch and not return because otherwise we may skip clearing
>>> the xfs-internal read-only flag. This will only show up on some
>>> operations like touch because most read-only checks are done by the VFS
>>> which things this filesystem is r/w. Eventually we should replace the
>>> XFS read-only flag with a helper that always checks the VFS flag to make
>>> sure they can never get out of sync.
>>>
>>> Bug reported and fix verified by Marcel Beister on #xfs.
>> Seems reasonable.
>>
>> I think this is 2.6.27.1 material?
>
> Yes.
>
>
The recent bug on oss.sgi.com is probably the same; I'm updating it now.
-Eric
prev parent reply other threads:[~2008-10-12 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 12:30 [PATCH] fix remount rw with unrecognized options Christoph Hellwig
2008-10-12 22:19 ` Eric Sandeen
2008-10-12 22:20 ` Christoph Hellwig
2008-10-12 22:21 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F27878.7050303@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox