* [PATCH] remove exports of inline functions
@ 2008-10-06 18:16 Christoph Hellwig
2008-10-15 10:48 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-10-06 18:16 UTC (permalink / raw)
To: xfs
Recent gcc starts to complain about exports of functions marked static
inline, so let's get rid of those.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:08:33.000000000 +0000
+++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:09:58.000000000 +0000
@@ -153,8 +153,6 @@
EXPORT_SYMBOL(kmem_zalloc);
EXPORT_SYMBOL(kmem_zone_alloc);
EXPORT_SYMBOL(kmem_zalloc_greedy);
-EXPORT_SYMBOL(kmem_zone_free);
-EXPORT_SYMBOL(kmem_zone_init);
EXPORT_SYMBOL(kmem_zone_zalloc);
EXPORT_SYMBOL(xfs_address_space_operations);
EXPORT_SYMBOL(xfs_dir_file_operations);
@@ -217,8 +215,6 @@
EXPORT_SYMBOL(xfs_finish_reclaim_all);
EXPORT_SYMBOL(xfs_freesb);
EXPORT_SYMBOL(xfs_fs_cmn_err);
-EXPORT_SYMBOL(xfs_highbit32);
-EXPORT_SYMBOL(xfs_highbit64);
EXPORT_SYMBOL(xfs_idestroy);
EXPORT_SYMBOL(xfs_iextract);
EXPORT_SYMBOL(xfs_iext_add);
@@ -227,10 +223,7 @@
EXPORT_SYMBOL(xfs_iext_idx_to_irec);
EXPORT_SYMBOL(xfs_iext_insert);
EXPORT_SYMBOL(xfs_iext_remove);
-EXPORT_SYMBOL(xfs_iflock);
-EXPORT_SYMBOL(xfs_iflock_nowait);
EXPORT_SYMBOL(xfs_iflush);
-EXPORT_SYMBOL(xfs_ifunlock);
EXPORT_SYMBOL(xfs_iget);
EXPORT_SYMBOL(xfs_ilock);
EXPORT_SYMBOL(xfs_ilock_map_shared);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove exports of inline functions
2008-10-06 18:16 [PATCH] remove exports of inline functions Christoph Hellwig
@ 2008-10-15 10:48 ` Christoph Hellwig
2008-10-16 0:19 ` Donald Douwsma
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-10-15 10:48 UTC (permalink / raw)
To: xfs
On Mon, Oct 06, 2008 at 08:16:26PM +0200, Christoph Hellwig wrote:
> Recent gcc starts to complain about exports of functions marked static
> inline, so let's get rid of those.
note that the complain is in the form of a kernel doesn't link, so any
chance we could get this patch in?
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:08:33.000000000 +0000
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:09:58.000000000 +0000
> @@ -153,8 +153,6 @@
> EXPORT_SYMBOL(kmem_zalloc);
> EXPORT_SYMBOL(kmem_zone_alloc);
> EXPORT_SYMBOL(kmem_zalloc_greedy);
> -EXPORT_SYMBOL(kmem_zone_free);
> -EXPORT_SYMBOL(kmem_zone_init);
> EXPORT_SYMBOL(kmem_zone_zalloc);
> EXPORT_SYMBOL(xfs_address_space_operations);
> EXPORT_SYMBOL(xfs_dir_file_operations);
> @@ -217,8 +215,6 @@
> EXPORT_SYMBOL(xfs_finish_reclaim_all);
> EXPORT_SYMBOL(xfs_freesb);
> EXPORT_SYMBOL(xfs_fs_cmn_err);
> -EXPORT_SYMBOL(xfs_highbit32);
> -EXPORT_SYMBOL(xfs_highbit64);
> EXPORT_SYMBOL(xfs_idestroy);
> EXPORT_SYMBOL(xfs_iextract);
> EXPORT_SYMBOL(xfs_iext_add);
> @@ -227,10 +223,7 @@
> EXPORT_SYMBOL(xfs_iext_idx_to_irec);
> EXPORT_SYMBOL(xfs_iext_insert);
> EXPORT_SYMBOL(xfs_iext_remove);
> -EXPORT_SYMBOL(xfs_iflock);
> -EXPORT_SYMBOL(xfs_iflock_nowait);
> EXPORT_SYMBOL(xfs_iflush);
> -EXPORT_SYMBOL(xfs_ifunlock);
> EXPORT_SYMBOL(xfs_iget);
> EXPORT_SYMBOL(xfs_ilock);
> EXPORT_SYMBOL(xfs_ilock_map_shared);
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove exports of inline functions
2008-10-15 10:48 ` Christoph Hellwig
@ 2008-10-16 0:19 ` Donald Douwsma
0 siblings, 0 replies; 3+ messages in thread
From: Donald Douwsma @ 2008-10-16 0:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> On Mon, Oct 06, 2008 at 08:16:26PM +0200, Christoph Hellwig wrote:
>> Recent gcc starts to complain about exports of functions marked static
>> inline, so let's get rid of those.
>
> note that the complain is in the form of a kernel doesn't link, so any
> chance we could get this patch in?
Yes, picking it up now.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c
>> ===================================================================
>> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:08:33.000000000 +0000
>> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_ksyms.c 2008-10-07 01:09:58.000000000 +0000
>> @@ -153,8 +153,6 @@
>> EXPORT_SYMBOL(kmem_zalloc);
>> EXPORT_SYMBOL(kmem_zone_alloc);
>> EXPORT_SYMBOL(kmem_zalloc_greedy);
>> -EXPORT_SYMBOL(kmem_zone_free);
>> -EXPORT_SYMBOL(kmem_zone_init);
>> EXPORT_SYMBOL(kmem_zone_zalloc);
>> EXPORT_SYMBOL(xfs_address_space_operations);
>> EXPORT_SYMBOL(xfs_dir_file_operations);
>> @@ -217,8 +215,6 @@
>> EXPORT_SYMBOL(xfs_finish_reclaim_all);
>> EXPORT_SYMBOL(xfs_freesb);
>> EXPORT_SYMBOL(xfs_fs_cmn_err);
>> -EXPORT_SYMBOL(xfs_highbit32);
>> -EXPORT_SYMBOL(xfs_highbit64);
>> EXPORT_SYMBOL(xfs_idestroy);
>> EXPORT_SYMBOL(xfs_iextract);
>> EXPORT_SYMBOL(xfs_iext_add);
>> @@ -227,10 +223,7 @@
>> EXPORT_SYMBOL(xfs_iext_idx_to_irec);
>> EXPORT_SYMBOL(xfs_iext_insert);
>> EXPORT_SYMBOL(xfs_iext_remove);
>> -EXPORT_SYMBOL(xfs_iflock);
>> -EXPORT_SYMBOL(xfs_iflock_nowait);
>> EXPORT_SYMBOL(xfs_iflush);
>> -EXPORT_SYMBOL(xfs_ifunlock);
>> EXPORT_SYMBOL(xfs_iget);
>> EXPORT_SYMBOL(xfs_ilock);
>> EXPORT_SYMBOL(xfs_ilock_map_shared);
> ---end quoted text---
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-16 0:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-06 18:16 [PATCH] remove exports of inline functions Christoph Hellwig
2008-10-15 10:48 ` Christoph Hellwig
2008-10-16 0:19 ` Donald Douwsma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox