From: Peter Leckie <pleckie@sgi.com>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: crash with latest code drop.
Date: Thu, 16 Oct 2008 12:43:10 +1000 [thread overview]
Message-ID: <48F6AA3E.8030902@sgi.com> (raw)
In-Reply-To: <48F5A104.5060506@sgi.com>
>> - it's the same as
>> the first report - deferencing the linux inode without first having
>> a refernce on it.
>>
>
> Yes it resolves the issue.
I spoke to soon, Ooops as follows:
<1>BUG: unable to handle kernel NULL pointer dereference at 0000000000000208
<1>IP: [<ffffffff802a37de>] igrab+0x10/0x30
<4>PGD 6ac33067 PUD 7dda2067 PMD 0
<0>Oops: 0000 [1] SMP
[0]kdb> bt
Stack traceback for pid 5195
0xffff8800378e4c50 5195 5094 1 0 R 0xffff8800378e4fb8
*bulkstat_unlink
sp ip Function (args)
0xffff88007d5abde8 0xffffffff802a37de igrab+0x10 (0x0)
0xffff88007d5abe20 0xffffffffa01f3623 [xfs]xfs_sync_inodes_ag+0xf4
(0xffff88003756e288, invalid, invalid)
0xffff88007d5abe80 0xffffffffa01f3853 [xfs]xfs_sync_inodes+0x63
(0xffff88003756e288, invalid)
0xffff88007d5abec0 0xffffffffa01f3919 [xfs]xfs_quiesce_data+0x13
(0xffff88003756e288)
0xffff88007d5abee0 0xffffffffa01f1800 [xfs]xfs_fs_sync_super+0x2b
(0xffff88007f1c09c8)
0xffff88007d5abf40 0xffffffff80292fd2 sync_filesystems+0xae (invalid)
0xffff88007d5abf60 0xffffffff802af48b do_sync+0x2f (0x1)
0xffff88007d5abf70 0xffffffff802af4c4 sys_sync+0xe
bb_special_case: Invalid bb_reg_state.memory, missing trailing entries
bb_special_case: on transfer to int_with_check
Assuming system_call_fastpath is 'pass through' with 6 register parameters
kdb_bb: 0xffffffff8020be0b [kernel]system_call_fastpath failed at
0xffffffff8020be98
Using old style backtrace, unreliable with no arguments
sp ip Function (args)
0xffff88007d5abde8 0xffffffff802a37de igrab+0x10
0xffff88007d5abe10 0xffffffff802a37de igrab+0x10
0xffff88007d5abe20 0xffffffffa01f3623 [xfs]xfs_sync_inodes_ag+0xf4
0xffff88007d5abe80 0xffffffffa01f3853 [xfs]xfs_sync_inodes+0x63
0xffff88007d5abec0 0xffffffffa01f3919 [xfs]xfs_quiesce_data+0x13
0xffff88007d5abec8 0xffffffff802452b9 autoremove_wake_function
0xffff88007d5abee0 0xffffffffa01f1800 [xfs]xfs_fs_sync_super+0x2b
0xffff88007d5abf00 0xffffffff8043b871 __down_read+0x12
0xffff88007d5abf10 0xffffffffa024d395 [ext3]ext3_sync_fs+0x46
0xffff88007d5abf40 0xffffffff80292fd2 sync_filesystems+0xae
0xffff88007d5abf60 0xffffffff802af48b do_sync+0x2f
0xffff88007d5abf70 0xffffffff802af4c4 sys_sync+0xe
Adding the following resolved the issue however you may wish to solve it
in another manner.
@@ -102,7 +102,7 @@ xfs_sync_inodes_ag(
* in reclaim. Leave it for the reclaim code to flush.
*/
inode = VFS_I(ip);
- if (!igrab(inode)) {
+ if (!inode || !igrab(inode)) {
read_unlock(&pag->pag_ici_lock);
continue;
}
Thanks,
Pete
next prev parent reply other threads:[~2008-10-16 1:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 1:49 crash with latest code drop Peter Leckie
2008-10-15 1:18 ` Dave Chinner
2008-10-15 2:29 ` Christoph Hellwig
2008-10-15 3:16 ` Dave Chinner
2008-10-15 3:24 ` Christoph Hellwig
2008-10-15 3:51 ` Dave Chinner
2008-10-15 5:50 ` Peter Leckie
2008-10-15 6:19 ` Dave Chinner
2008-10-15 7:51 ` Peter Leckie
2008-10-16 2:43 ` Peter Leckie [this message]
2008-10-16 5:55 ` Dave Chinner
2008-10-16 9:00 ` Christoph Hellwig
2008-10-17 1:01 ` Lachlan McIlroy
2008-10-22 6:19 ` Dave Chinner
2008-10-23 4:23 ` Peter Leckie
2008-10-23 5:39 ` Dave Chinner
2008-10-15 3:47 ` Peter Leckie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F6AA3E.8030902@sgi.com \
--to=pleckie@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox