Re: crash with latest code drop.

Dave Chinner
2008-10-16T05:53:54Z

On Thu, Oct 16, 2008 at 12:43:10PM +1000, Peter Leckie wrote:
>
>>> - it's the same as
>>> the first report - deferencing the linux inode without first having
>>> a refernce on it.
>>>
>>
>> Yes it resolves the issue.
>
> I spoke to soon, Ooops as follows:
....

> Adding the following resolved the issue however you may wish to solve it
> in another manner.
>
> @@ -102,7 +102,7 @@ xfs_sync_inodes_ag(
> * in reclaim. Leave it for the reclaim code to flush.
> */
> inode = VFS_I(ip);
> - if (!igrab(inode)) {
> + if (!inode || !igrab(inode)) {
> read_unlock(&pag->pag_ici_lock);
> continue;
> }

Yes, or you could simply apply the "combine linux/XFS inode" patch
series and then VFS_I(ip) will never, ever return NULL.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com