Re: crash with latest code drop.

Lachlan McIlroy
2008-10-17T00:01:19Z

Christoph Hellwig wrote:
> On Thu, Oct 16, 2008 at 12:43:10PM +1000, Peter Leckie wrote:
>> Adding the following resolved the issue however you may wish to solve it
>> in another manner.
>>
>> @@ -102,7 +102,7 @@ xfs_sync_inodes_ag(
>> * in reclaim. Leave it for the reclaim code to flush.
>> */
>> inode = VFS_I(ip);
>> - if (!igrab(inode)) {
>> + if (!inode || !igrab(inode)) {
>> read_unlock(&pag->pag_ici_lock);
>> continue;
>> }
>>
>
> This would be the correct fix for the current code, but can you please
> put in the Inode/XFS Inode unification patches? At least I have only
> QAed the whole patchkit, and from the issues here it seems like Dave did
> the same.
That patchset is already in.

>
> And with that it would also be very good if there was any chance Dave
> and me (and all others) could actually access the current tree. The
> ptools -> CVS export has been broken for mor than two days, and there
> is no uptodate git tree eiter, so us external developers are completely
> tapping in the dark vs the current tree.
We had no idea the CVS tree was not updating. I'll get the OSS trees
updated today.