From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions
Date: Tue, 21 Oct 2008 10:10:39 -0500 [thread overview]
Message-ID: <48FDF0EF.3000807@sandeen.net> (raw)
In-Reply-To: <20081021133104.GA10372@infradead.org>
Christoph Hellwig wrote:
> On Tue, Oct 21, 2008 at 08:22:50AM -0500, Eric Sandeen wrote:
>> Christoph Hellwig wrote:
>>> On Mon, Oct 20, 2008 at 05:24:03PM -0500, Eric Sandeen wrote:
>> ...
>>
>>>> /*
>>>> - * Fcntl interface to xfs_bmapi.
>>>> + * ioctl interface to xfs_bmapi.
>>>> */
>>>> /*
>>>> - * Fcntl interface to xfs_bmapi.
>>>> + * ioctl interface to xfs_bmapi.
>>>> */
>>> Well, it will be for fiemap, too. And the comment doesn't make much
>>> sense either. Either remove it completely or replace it by something
>>> that makes sense.
>>>
>> well aren't XFS_IOC_GETBMAP(X) and fiemap _both_ ioctl interfaces to
>> xfs_bmapi?
>
> Hmm, From the syscall point of view fiemap is indeed an ioctl, too.
> But then again the point of this function isn't do anything
> ioctl-related, but to allow to get a list of all extents for an inode
> and format them arbitrarily.
arright... if the comment is the only concern, I'm happy with that ;)
-Eric
prev parent reply other threads:[~2008-10-21 15:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 22:24 [PATCH 1/2, RFC] convert xfs_getbmap to take formatter functions Eric Sandeen
2008-10-21 8:07 ` Christoph Hellwig
2008-10-21 13:22 ` Eric Sandeen
2008-10-21 13:31 ` Christoph Hellwig
2008-10-21 15:10 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FDF0EF.3000807@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox