From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@sandeen.net>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2] convert xfs_getbmap to take formatter functions
Date: Thu, 23 Oct 2008 19:44:08 -0500 [thread overview]
Message-ID: <49011A58.9040403@sandeen.net> (raw)
In-Reply-To: <20081023233538.GG18495@disturbed>
Dave Chinner wrote:
> On Thu, Oct 23, 2008 at 06:07:53PM -0500, Eric Sandeen wrote:
>> Preliminary work to hook up fiemap, this allows us to pass in an
>> arbitrary formatter to copy extent data back to userspace.
>
> Is there a fiemap test program around anywhere?
>
> If so, would it be appropriate to include it in xfstests and write
> a quick regression test for it? We'd probably need to also check
> xfs_bmap gives the same output as fiemap....
I have a very hacky app/test that can exercise the interface; there is
nothing, as far as I know, that will create "every" possible combination
of output and test for correct output ... but yes, this interface should
get at least something in the test suite.
-Eric
> Cheers,
>
> Dave.
prev parent reply other threads:[~2008-10-24 0:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 23:07 [PATCH 1/2] convert xfs_getbmap to take formatter functions Eric Sandeen
2008-10-23 23:35 ` Dave Chinner
2008-10-24 0:44 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49011A58.9040403@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox