From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] clean up printk formats with DMAPI_DEBUG
Date: Sat, 25 Oct 2008 15:27:19 -0500 [thread overview]
Message-ID: <49038127.8010608@sandeen.net> (raw)
In-Reply-To: <20081025202005.GC28002@infradead.org>
Christoph Hellwig wrote:
> On Sat, Oct 25, 2008 at 08:14:25AM -0500, Eric Sandeen wrote:
>> #ifdef CONFIG_DMAPI_DEBUG
>> - printk("xfs_dm_round_hole: off %lu, len %ld, align %lu, "
>> - "filesize %llu, roff %ld, rlen %ld\n",
>> + printk("xfs_dm_round_hole: off %lld, len %llu, align %llu, "
>> + "filesize %lld, roff %lld, rlen %llu\n",
>> offset, length, align, filesize, *roff, *rlen);
>
> We'd still need casts to (unsigned) long long because the 64 bit
> types may be either variant on 64 bit platforms.
>
Ah crud you're right, I forgot that s64 was sometimes just a "long"
Bah; is there no format that does this cleanly? :)
-Eric
next prev parent reply other threads:[~2008-10-25 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 13:14 [PATCH] clean up printk formats with DMAPI_DEBUG Eric Sandeen
2008-10-25 20:20 ` Christoph Hellwig
2008-10-25 20:27 ` Eric Sandeen [this message]
2008-11-21 21:18 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49038127.8010608@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox