From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2 v2] hook up fiemap & associated formatter
Date: Sat, 25 Oct 2008 23:38:17 -0500 [thread overview]
Message-ID: <4903F439.1070605@sandeen.net> (raw)
In-Reply-To: <20081025202657.GG28002@infradead.org>
Christoph Hellwig wrote:
>> +#define XFS_FIEMAP_FLAGS (FIEMAP_FLAG_SYNC|FIEMAP_FLAG_XATTR)
>
> Why do we need FIEMAP_FLAG_SYNC in here? That flag is implemented in
> the VFS and should be handled there. (Probably more a question for
> the generic implementation than your patch)
well, sorta, it calls filemap_write_and_wait but no lock is held to keep
that consistent when the filesystem gets to it... IMHO it *should*
probably be up to the fs to handle the sync flag. But anyway, for it
all to hang together I think we need to tell it that we understand this
flag.
-Eric
>> +
>> +STATIC int xfs_fiemap_format(
>
> STATIC int
> xfs_fiemap_format(
>
>
>
> Buit the meat of the patch looks good to me.
>
>
next prev parent reply other threads:[~2008-10-26 4:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 13:26 [PATCH 0/2 v2] hook xfs to fiemap ioctl Eric Sandeen
2008-10-25 13:33 ` [PATCH 1/2 v2] convert xfs_getbmap to take formatter functions Eric Sandeen
2008-10-25 20:25 ` Christoph Hellwig
2008-10-25 20:27 ` Christoph Hellwig
2008-10-25 20:28 ` Eric Sandeen
2008-10-25 13:34 ` [PATCH 2/2 v2] hook up fiemap & associated formatter Eric Sandeen
2008-10-25 20:26 ` Christoph Hellwig
2008-10-26 4:38 ` Eric Sandeen [this message]
2008-10-25 20:20 ` [PATCH 0/2 v2] hook xfs to fiemap ioctl Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4903F439.1070605@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox