From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726E3C17442 for ; Wed, 13 Nov 2019 13:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 550B5222CD for ; Wed, 13 Nov 2019 13:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727137AbfKMNII (ORCPT ); Wed, 13 Nov 2019 08:08:08 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:38290 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726186AbfKMNIH (ORCPT ); Wed, 13 Nov 2019 08:08:07 -0500 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E4392C1CE9603A61D42E; Wed, 13 Nov 2019 21:08:04 +0800 (CST) Received: from [127.0.0.1] (10.173.220.96) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.439.0; Wed, 13 Nov 2019 21:07:54 +0800 Subject: Re: question about xfs tests involved logprint To: , CC: "zhangyi (F)" , "zhengbin (A)" , References: From: "yukuai (C)" Message-ID: <49254d5b-5250-e25f-8629-e2cc83fba05f@huawei.com> Date: Wed, 13 Nov 2019 21:07:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.96] X-CFilter-Loop: Reflected Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hi list, I'm testing xfs filesytem recently, and I think some tests is wrong. for example: xfs/018 At first, this test mkfs with '-l version=1' without setting 'crc' to 0(crc is 1 bt default), which will fail. Next, the expected output of xfs_logprint, 018.op, is obviously wrong. 018.op include many ops with 'START' TRANS flag, which is impossible with delayed logging enabled. All the log items should be in the same checkpoint. There are some other tests have the same issue. Maybe the problem is due to when delayed logging was enabled, these tests didn't get modified as they supposed to. Thanks Yu Kuai