From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH V2] clean up printk formats with DMAPI_DEBUG
Date: Fri, 21 Nov 2008 15:18:56 -0600 [thread overview]
Message-ID: <492725C0.2070302@sandeen.net> (raw)
In-Reply-To: <49038127.8010608@sandeen.net>
Eric Sandeen wrote:
> Christoph Hellwig wrote:
>
>> On Sat, Oct 25, 2008 at 08:14:25AM -0500, Eric Sandeen wrote:
>>
>>> #ifdef CONFIG_DMAPI_DEBUG
>>> - printk("xfs_dm_round_hole: off %lu, len %ld, align %lu, "
>>> - "filesize %llu, roff %ld, rlen %ld\n",
>>> + printk("xfs_dm_round_hole: off %lld, len %llu, align %llu, "
>>> + "filesize %lld, roff %lld, rlen %llu\n",
>>> offset, length, align, filesize, *roff, *rlen);
>>>
>> We'd still need casts to (unsigned) long long because the 64 bit
>> types may be either variant on 64 bit platforms.
>>
> Ah crud you're right, I forgot that s64 was sometimes just a "long"
>
> Bah; is there no format that does this cleanly? :)
>
> -Eric
>
Fix up warnings when building with DMAPI_DEBUG
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
--
Index: linux-2.6-xfs/fs/xfs/dmapi/xfs_dm.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/dmapi/xfs_dm.c
+++ linux-2.6-xfs/fs/xfs/dmapi/xfs_dm.c
@@ -2334,9 +2334,11 @@ xfs_dm_round_hole(
return -EINVAL; /* requested length is too small */
}
#ifdef CONFIG_DMAPI_DEBUG
- printk("xfs_dm_round_hole: off %lu, len %ld, align %lu, "
- "filesize %llu, roff %ld, rlen %ld\n",
- offset, length, align, filesize, *roff, *rlen);
+ printk("xfs_dm_round_hole: off %lld, len %llu, align %llu, "
+ "filesize %lld, roff %lld, rlen %llu\n",
+ (long long)offset, (unsigned long long)length,
+ (unsigned long long)align, filesize, (long long)*roff,
+ (unsigned long long)*rlen);
#endif
return 0; /* hole geometry successfully rounded */
}
@@ -2467,8 +2469,9 @@ xfs_dm_punch_hole(
}
#ifdef CONFIG_DMAPI_DEBUG
- printk("xfs_dm_punch_hole: off %lu, len %ld, align %lu\n",
- off, len, align);
+ printk("xfs_dm_punch_hole: off %lld, len %llu, align %llu\n",
+ (long long)off, (unsigned long long)len,
+ (unsigned long long)align);
#endif
error = xfs_change_file_space(ip, XFS_IOC_UNRESVSP, &bf,
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-11-21 21:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 13:14 [PATCH] clean up printk formats with DMAPI_DEBUG Eric Sandeen
2008-10-25 20:20 ` Christoph Hellwig
2008-10-25 20:27 ` Eric Sandeen
2008-11-21 21:18 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492725C0.2070302@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox