[PATCH] xfsdump: don't redeclare offsetoff

[PATCH] xfsdump: don't redeclare offsetoff

[Christoph Hellwig]

Don't redeclare offsetof, we already include <stddef.h> to get it and
modern gcc will complain about the redeclaration.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfs-cmds/xfsdump/common/getdents.c
===================================================================
--- xfs-cmds.orig/xfsdump/common/getdents.c	2008-11-13 18:45:11.000000000 +0100
+++ xfs-cmds/xfsdump/common/getdents.c	2008-11-13 18:45:18.000000000 +0100
@@ -72,8 +72,6 @@ extern int __have_no_getdents64;
 # endif
 #endif
 
-#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
-
 
 /* For Linux we need a special version of this file since the
    definition of `struct dirent' is not the same for the kernel and

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsdump: don't redeclare offsetoff

[Eric Sandeen]

Christoph Hellwig wrote:
> Don't redeclare offsetof, we already include <stddef.h> to get it and
> modern gcc will complain about the redeclaration.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfs-cmds/xfsdump/common/getdents.c
> ===================================================================
> --- xfs-cmds.orig/xfsdump/common/getdents.c	2008-11-13 18:45:11.000000000 +0100
> +++ xfs-cmds/xfsdump/common/getdents.c	2008-11-13 18:45:18.000000000 +0100
> @@ -72,8 +72,6 @@ extern int __have_no_getdents64;
>  # endif
>  #endif
>  
> -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
> -

ACK.  I'd noticed this too, thanks.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs