public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Lachlan McIlroy <lachlan@sgi.com>
To: Donald Douwsma <donaldd@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: Assertion failed: atomic_read(&mp->m_active_trans)
Date: Tue, 02 Dec 2008 14:25:29 +1100	[thread overview]
Message-ID: <4934AAA9.5090405@sgi.com> (raw)
In-Reply-To: <492BB095.1000104@sgi.com>

That looks fine to me.  Just make sure the PV doesn't get closed when
you check in the changes since the real problem is still unresolved.

Donald Douwsma wrote:
> We still occasionally see transactions in flight after remounting
> read-only. This has come up a few times in the past, but we never
> seem to have gotten to the bottom of it.
> 
> http://www.gossamer-threads.com/lists/linux/kernel/868139
> 
> Most recently we've seen this on 2.6.27, when unmounting the root
> filesystem during shutdown/reboot.
> 
> Stack traceback for pid 13170
> 0xffff81024dcd9080    13170    12901  1    1   R  0xffff81024dcd93c0 *mount
> rsp                rip                Function (args)
> 0xffff8101fb977d18 0xffffffff803b8acd assfail+0x1a (invalid, invalid, invalid)
> 0xffff8101fb977d50 0xffffffff803a57e4 xfs_attr_quiesce+0x4a (0xffff8102211e4b20)
> 0xffff8101fb977d70 0xffffffff803a589b xfs_mntupdate+0x7c (0xffff8102211e4b20, invalid, invalid)
> 0xffff8101fb977d90 0xffffffff803b7cf6 xfs_fs_remount+0x49 (invalid, 0xffff8101fb977dd4, invalid)
> 0xffff8101fb977dc0 0xffffffff802830fe do_remount_sb+0xe9 (0xffff81025c804670, invalid, 0xffff8101ee490000, invalid)
> 0xffff8101fb977e00 0xffffffff8029698d do_remount+0x7d (0xffff8101fb977e58, invalid, invalid, 0xffff8101ee490000)
> 0xffff8101fb977e40 0xffffffff802974fd do_mount+0x13b (0xffff8102079c2000, 0xffff8102004ea000, 0xffff810219cb0000, invalid, 0xffff8101ee490000)
> 0xffff8101fb977f20 0xffffffff8029761a sys_mount+0x89 (0x523d90, invalid, invalid, 0xffffffffc0ed0021, 0x523e30)
> 0xffff8101fb977f80 0xffffffff8020b18b system_call_after_swapgs+0x7b (invalid, invalid, invalid, invalid, invalid, invalid)
> 
> Previously we've discussed changing the ASSERT_ALWAYS to a normal
> ASSERT to lessen the impact for users. Any objections to doing this
> until we fix the underlying problem?
> 
> Don
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2008-12-02  3:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25  8:00 Assertion failed: atomic_read(&mp->m_active_trans) Donald Douwsma
2008-12-02  3:25 ` Lachlan McIlroy [this message]
2008-12-03 10:48   ` Christoph Hellwig
2008-12-03 21:39     ` Dave Chinner
2008-12-04  5:36       ` Donald Douwsma
2008-12-04 12:33       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4934AAA9.5090405@sgi.com \
    --to=lachlan@sgi.com \
    --cc=donaldd@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox