From: Lachlan McIlroy <lachlan@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io
Date: Fri, 05 Dec 2008 15:06:25 +1100 [thread overview]
Message-ID: <4938A8C1.7030103@sgi.com> (raw)
In-Reply-To: <4938A4C1.9010401@sandeen.net>
Eric Sandeen wrote:
> Tim mentioned something about the code in xfs_buf_iodone_work()
> which detects barrier failures post-mount, as added in commit
> 0bfefc46dc028df60120acdb92062169c9328769,
> [XFS] Barriers need to be dynamically checked and switched off
>
> if ((bp->b_error == EOPNOTSUPP) &&
> (bp->b_flags & (XBF_ORDERED|XBF_ASYNC)) == (XBF_ORDERED|XBF_ASYNC)) {
> XB_TRACE(bp, "ordered_retry", bp->b_iodone);
> bp->b_flags &= ~XBF_ORDERED;
> bp->b_flags |= _XFS_BARRIER_FAILED;
> ...
>
> but it seems that nothing ever sets EOPNOTSUPP on b_error, so
> this path would never be hit.
>
> I think that we need to do something like below, totally untested,
> to ensure that bio errors get set on b_error, if we're looking
> for them by name, no?
>
> (I'm not sure if we still need the BIO_UPTODATE test, or if
> we can just look at the error we're given and be done?)
>
> Does this seem about right?
>
> Thanks,
> -Eric
>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
> @@ -1114,8 +1114,10 @@ xfs_buf_bio_end_io(
> unsigned int blocksize = bp->b_target->bt_bsize;
> struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
>
> - if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
> - bp->b_error = EIO;
> + if (error)
> + bp->b_error = XFS_ERROR(-error);
> + else if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
> + bp->b_error = XFS_ERROR(EIO);
I would suggest this:
@@ -1114,8 +1140,7 @@ xfs_buf_bio_end_io(
unsigned int blocksize = bp->b_target->bt_bsize;
struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
- if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
- bp->b_error = EIO;
+ xfs_buf_ioerror(bp, -error);
do {
struct page *page = bvec->bv_page;
The BIO_UPTODATE checks have already been done before calling this function
and error has been set appropriately so we can just use it.
>
> do {
> struct page *page = bvec->bv_page;
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-05 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 3:49 [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io Eric Sandeen
2008-12-05 3:59 ` Eric Sandeen
2008-12-05 4:06 ` Lachlan McIlroy [this message]
2008-12-05 4:09 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4938A8C1.7030103@sgi.com \
--to=lachlan@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox