From: Eric Sandeen <sandeen@sandeen.net>
To: lachlan@sgi.com
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io
Date: Thu, 04 Dec 2008 22:09:57 -0600 [thread overview]
Message-ID: <4938A995.6040609@sandeen.net> (raw)
In-Reply-To: <4938A8C1.7030103@sgi.com>
Lachlan McIlroy wrote:
> I would suggest this:
>
> @@ -1114,8 +1140,7 @@ xfs_buf_bio_end_io(
> unsigned int blocksize = bp->b_target->bt_bsize;
> struct bio_vec *bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
>
> - if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
> - bp->b_error = EIO;
> + xfs_buf_ioerror(bp, -error);
oh, sure. I forgot we had the wrapper to set the error ... :)
> The BIO_UPTODATE checks have already been done before calling this function
> and error has been set appropriately so we can just use it.
ah so it is. yeah, makes perfect sense.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-05 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-05 3:49 [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io Eric Sandeen
2008-12-05 3:59 ` Eric Sandeen
2008-12-05 4:06 ` Lachlan McIlroy
2008-12-05 4:09 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4938A995.6040609@sandeen.net \
--to=sandeen@sandeen.net \
--cc=lachlan@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox