public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Timothy Shimmin <tes@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsqa: add testcase for ->setattr permission checking
Date: Wed, 10 Dec 2008 15:36:27 +1100	[thread overview]
Message-ID: <493F474B.8020106@sgi.com> (raw)
In-Reply-To: <493F34CA.3040101@sgi.com>

Timothy Shimmin wrote:
> For chown:
> 	"If the specified file is a regular file, one or more of the S_IXUSR,
> 	S_IXGRP, or S_IXOTH bits of the file mode are set, and the process
> 	does not have appropriate privileges, the set-user-ID (S_ISUID) and
> 	set-group-ID (S_ISGID) bits of the file mode shall be cleared upon
> 	successful return from chown(). If the specified file is a regular
> 	file, one or more of the S_IXUSR, S_IXGRP, or S_IXOTH bits of the
> 	file mode are set, and the process has appropriate privileges, it
> 	is implementation-defined whether the set-user-ID and set-group-ID
> 	bits are altered. If the chown() function is successfully invoked
> 	on a file that is not a regular file and one or more of the S_IXUSR,
> 	S_IXGRP, or S_IXOTH bits of the file mode are set, the set-user-ID
> 	and set-group-ID bits may be cleared."
> 
> reg file + mode-bits set + no appropriate privileges -> clear suid,sgid
> reg file + mode-bits set + appropriate privileges -> maybe clear suid,sgid
> non reg file + mode-bits set + chown success on file (??) -> maybe clear suid/sgid
> 
s/mode-bits/exec-mode-bits/

--Tim

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2008-12-10  4:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 14:20 [PATCH] xfsqa: add testcase for ->setattr permission checking Christoph Hellwig
2008-12-03  7:24 ` Timothy Shimmin
2008-12-08  5:48 ` Timothy Shimmin
2008-12-09  9:55   ` Christoph Hellwig
2008-12-10  3:17     ` Timothy Shimmin
2008-12-10  4:36       ` Timothy Shimmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=493F474B.8020106@sgi.com \
    --to=tes@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox