From: Eric Sandeen <sandeen@sandeen.net>
To: Arkadiusz Miskiewicz <arekm@maven.pl>
Cc: linux-xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_quota: Warn if specified non-zero quota will be round down to zero.
Date: Mon, 15 Dec 2008 19:27:24 -0600 [thread overview]
Message-ID: <494703FC.7080203@sandeen.net> (raw)
In-Reply-To: <1229383657-45951-1-git-send-email-arekm@maven.pl>
Arkadiusz Miskiewicz wrote:
> User specified quota limit is internally converted to "basic blocks"
> unit (512 bytes in size). Quota value will be silently converted
> to zero when user enters any value lower than 512 bytes.
>
> Warn in such case:
>
> : # ./xfs_quota -x -c "limit -u bsoft=431 12000" /home
> : xfs_quota: Warning: `431' in quota blocks is 0 (unlimited).
Looks good to me.
-Eric
> ---
> xfsprogs/po/pl.po | 5 +++++
> xfsprogs/quota/edit.c | 2 ++
> 2 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/xfsprogs/po/pl.po b/xfsprogs/po/pl.po
> index b4e1d76..d13184b 100644
> --- a/xfsprogs/po/pl.po
> +++ b/xfsprogs/po/pl.po
> @@ -3670,6 +3670,11 @@ msgstr "%s: nieprawid
> msgid "%s: invalid project name: %s\n"
> msgstr "%s: nieprawid³owa nazwa projektu: %s\n"
>
> +#: ../quota/edit.c:237
> +#, c-format
> +msgid "%s: Warning: `%s' in quota blocks is 0 (unlimited).\n"
> +msgstr "%s: Uwaga: `%s' w blokach quoty oznacza 0 (nieograniczone).\n"
> +
> #: ../quota/edit.c:318
> #, c-format
> msgid "%s: unrecognised argument %s\n"
> diff --git a/xfsprogs/quota/edit.c b/xfsprogs/quota/edit.c
> index 15c72c4..ce7f7e9 100644
> --- a/xfsprogs/quota/edit.c
> +++ b/xfsprogs/quota/edit.c
> @@ -233,6 +233,8 @@ extractb(
> s = string + length + 1;
> v = (__uint64_t)cvtnum(blocksize, sectorsize, s);
> *value = v >> 9; /* syscalls use basic blocks */
> + if (v > 0 && *value == 0)
> + fprintf(stderr, _("%s: Warning: `%s' in quota blocks is 0 (unlimited).\n"), progname, s);
> return 1;
> }
> return 0;
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2008-12-16 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 23:27 [PATCH] xfs_quota: Warn if specified non-zero quota will be round down to zero Arkadiusz Miskiewicz
2008-12-16 1:27 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494703FC.7080203@sandeen.net \
--to=sandeen@sandeen.net \
--cc=arekm@maven.pl \
--cc=linux-xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox