From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Beregalov <a.beregalov@gmail.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err
Date: Wed, 17 Dec 2008 11:46:13 -0600 [thread overview]
Message-ID: <49493AE5.2050202@sandeen.net> (raw)
In-Reply-To: <20081217172736.GA10797@infradead.org>
Christoph Hellwig wrote:
> + if (mp) {
> + len = sprintf(message, "Filesystem \"%s\": ", mp->m_fsname);
> +
> + /*
> + * Skip the printk if we can't print anything useful
> + * due to an over-long device name.
> + */
> + if (len >= sizeof(message))
> + goto out;
Do we really want to drop the whole message if the fs name can't fit?
Maybe drop the fsname altogether and print the error anyway? Being
completely silent doesn't sound great...
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-17 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 17:27 [PATCH] avoid memory allocations in xfs_fs_vcmn_err Christoph Hellwig
2008-12-17 17:46 ` Eric Sandeen [this message]
2008-12-17 17:57 ` Christoph Hellwig
2008-12-17 18:04 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49493AE5.2050202@sandeen.net \
--to=sandeen@sandeen.net \
--cc=a.beregalov@gmail.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox