Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err

Christoph Hellwig
2008-12-17T17:57:53Z

On Wed, Dec 17, 2008 at 11:46:13AM -0600, Eric Sandeen wrote:
> Do we really want to drop the whole message if the fs name can't fit?
> Maybe drop the fsname altogether and print the error anyway? Being
> completely silent doesn't sound great...

That's what we effecitvely do now, except that we still call snprintf.
I think it's an unlikely enough case that we don't need to worry about
it. And if long enough device names become common we can just increase
the buffer size.