From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: couple small xfstest patches
Date: Mon, 22 Dec 2008 08:55:20 -0600 [thread overview]
Message-ID: <494FAA58.7070605@sandeen.net> (raw)
In-Reply-To: <20081222130824.GC12367@infradead.org>
Christoph Hellwig wrote:
> On Fri, Nov 21, 2008 at 01:45:23PM -0800, Matthew Kent wrote:
>> * 189 fails with external devices
>> * add a unified diff output option, find it easier on the eyes ;)
>
> Thanks, I'll put these into my queue. Question to the list: any
> arguments against just making unified diffs the default for xfsqa
> output?
none here; I run patched that way already.
>> Thanks!
>> --
>> Matthew Kent <mkent@magoazul.com>
>> http://magoazul.com
>> --- xfs-cmds/xfstests/common.orig 2008-11-21 13:19:47.000000000 -0800
>> +++ xfs-cmds/xfstests/common 2008-11-21 13:22:04.000000000 -0800
>> @@ -107,7 +107,7 @@
>> -nfs test NFS
>> -l line mode diff (default)
>> -xdiff graphical mode diff
>> - -diffu show unified diff
>> + -udiff show unified diff
>> -n show me, do not run tests
>> -q quick [deprecated]
>> -T output timestamps
>> @@ -158,7 +158,7 @@
>> fi
>> ;;
>>
>> - -diffu) # show unified diff
>> + -udiff) # show a unified diff
>> xpand=false
>> diff="$diff -u"
>> ;;
>> --- xfs-cmds/xfstests/189.orig 2008-11-21 13:43:33.000000000 -0800
>> +++ xfs-cmds/xfstests/189 2008-11-21 13:42:48.000000000 -0800
>> @@ -188,8 +188,8 @@
>> _need_to_be_root
>> _require_scratch
>>
>> -unset SCRATCH_OPTIONS
>> -unset MOUNT_OPTIONS
>> +unset SCRATCH_RTDEV
>> +unset SCRATCH_LOGDEV
>>
>> _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
> ---end quoted text---
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-22 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 21:45 couple small xfstest patches Matthew Kent
2008-11-21 22:17 ` Matthew Kent
2008-12-22 13:08 ` Christoph Hellwig
2008-12-22 14:55 ` Eric Sandeen [this message]
2008-12-29 11:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494FAA58.7070605@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox