* couple small xfstest patches
@ 2008-11-21 21:45 Matthew Kent
2008-11-21 22:17 ` Matthew Kent
2008-12-22 13:08 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Matthew Kent @ 2008-11-21 21:45 UTC (permalink / raw)
To: xfs
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
* 189 fails with external devices
* add a unified diff output option, find it easier on the eyes ;)
Thanks!
--
Matthew Kent <mkent@magoazul.com>
http://magoazul.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xfstest-unified_diff.patch --]
[-- Type: text/x-diff; name="xfstest-unified_diff.patch", Size: 562 bytes --]
--- xfs-cmds/xfstests/common.orig 2008-11-21 13:19:47.000000000 -0800
+++ xfs-cmds/xfstests/common 2008-11-21 13:22:04.000000000 -0800
@@ -107,7 +107,7 @@
-nfs test NFS
-l line mode diff (default)
-xdiff graphical mode diff
- -diffu show unified diff
+ -udiff show unified diff
-n show me, do not run tests
-q quick [deprecated]
-T output timestamps
@@ -158,7 +158,7 @@
fi
;;
- -diffu) # show unified diff
+ -udiff) # show a unified diff
xpand=false
diff="$diff -u"
;;
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: xfstest-189_fixexternal.patch --]
[-- Type: text/x-diff; name="xfstest-189_fixexternal.patch", Size: 323 bytes --]
--- xfs-cmds/xfstests/189.orig 2008-11-21 13:43:33.000000000 -0800
+++ xfs-cmds/xfstests/189 2008-11-21 13:42:48.000000000 -0800
@@ -188,8 +188,8 @@
_need_to_be_root
_require_scratch
-unset SCRATCH_OPTIONS
-unset MOUNT_OPTIONS
+unset SCRATCH_RTDEV
+unset SCRATCH_LOGDEV
_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
[-- Attachment #4: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: couple small xfstest patches
2008-11-21 21:45 couple small xfstest patches Matthew Kent
@ 2008-11-21 22:17 ` Matthew Kent
2008-12-22 13:08 ` Christoph Hellwig
1 sibling, 0 replies; 5+ messages in thread
From: Matthew Kent @ 2008-11-21 22:17 UTC (permalink / raw)
To: xfs
[-- Attachment #1: Type: text/plain, Size: 142 bytes --]
> * add a unified diff output option, find it easier on the eyes ;)
oops :)
fixed.
--
Matthew Kent <mkent@magoazul.com>
http://magoazul.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xfstest-unified_diff.patch --]
[-- Type: text/x-diff; name="xfstest-unified_diff.patch", Size: 582 bytes --]
--- xfs-cmds/xfstests/common.orig 2008-11-21 14:13:12.000000000 -0800
+++ xfs-cmds/xfstests/common 2008-11-21 14:15:37.000000000 -0800
@@ -107,6 +107,7 @@
-nfs test NFS
-l line mode diff (default)
-xdiff graphical mode diff
+ -udiff show unified diff
-n show me, do not run tests
-q quick [deprecated]
-T output timestamps
@@ -157,6 +158,11 @@
fi
;;
+ -udiff) # show a unified diff
+ xpand=false
+ diff="$diff -u"
+ ;;
+
-q) # "quick", no longer used - always quick :-)
xpand=false
;;
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: couple small xfstest patches
2008-11-21 21:45 couple small xfstest patches Matthew Kent
2008-11-21 22:17 ` Matthew Kent
@ 2008-12-22 13:08 ` Christoph Hellwig
2008-12-22 14:55 ` Eric Sandeen
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2008-12-22 13:08 UTC (permalink / raw)
To: Matthew Kent; +Cc: xfs
On Fri, Nov 21, 2008 at 01:45:23PM -0800, Matthew Kent wrote:
> * 189 fails with external devices
> * add a unified diff output option, find it easier on the eyes ;)
Thanks, I'll put these into my queue. Question to the list: any
arguments against just making unified diffs the default for xfsqa
output?
>
> Thanks!
> --
> Matthew Kent <mkent@magoazul.com>
> http://magoazul.com
> --- xfs-cmds/xfstests/common.orig 2008-11-21 13:19:47.000000000 -0800
> +++ xfs-cmds/xfstests/common 2008-11-21 13:22:04.000000000 -0800
> @@ -107,7 +107,7 @@
> -nfs test NFS
> -l line mode diff (default)
> -xdiff graphical mode diff
> - -diffu show unified diff
> + -udiff show unified diff
> -n show me, do not run tests
> -q quick [deprecated]
> -T output timestamps
> @@ -158,7 +158,7 @@
> fi
> ;;
>
> - -diffu) # show unified diff
> + -udiff) # show a unified diff
> xpand=false
> diff="$diff -u"
> ;;
> --- xfs-cmds/xfstests/189.orig 2008-11-21 13:43:33.000000000 -0800
> +++ xfs-cmds/xfstests/189 2008-11-21 13:42:48.000000000 -0800
> @@ -188,8 +188,8 @@
> _need_to_be_root
> _require_scratch
>
> -unset SCRATCH_OPTIONS
> -unset MOUNT_OPTIONS
> +unset SCRATCH_RTDEV
> +unset SCRATCH_LOGDEV
>
> _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: couple small xfstest patches
2008-12-22 13:08 ` Christoph Hellwig
@ 2008-12-22 14:55 ` Eric Sandeen
2008-12-29 11:37 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Eric Sandeen @ 2008-12-22 14:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Christoph Hellwig wrote:
> On Fri, Nov 21, 2008 at 01:45:23PM -0800, Matthew Kent wrote:
>> * 189 fails with external devices
>> * add a unified diff output option, find it easier on the eyes ;)
>
> Thanks, I'll put these into my queue. Question to the list: any
> arguments against just making unified diffs the default for xfsqa
> output?
none here; I run patched that way already.
>> Thanks!
>> --
>> Matthew Kent <mkent@magoazul.com>
>> http://magoazul.com
>> --- xfs-cmds/xfstests/common.orig 2008-11-21 13:19:47.000000000 -0800
>> +++ xfs-cmds/xfstests/common 2008-11-21 13:22:04.000000000 -0800
>> @@ -107,7 +107,7 @@
>> -nfs test NFS
>> -l line mode diff (default)
>> -xdiff graphical mode diff
>> - -diffu show unified diff
>> + -udiff show unified diff
>> -n show me, do not run tests
>> -q quick [deprecated]
>> -T output timestamps
>> @@ -158,7 +158,7 @@
>> fi
>> ;;
>>
>> - -diffu) # show unified diff
>> + -udiff) # show a unified diff
>> xpand=false
>> diff="$diff -u"
>> ;;
>> --- xfs-cmds/xfstests/189.orig 2008-11-21 13:43:33.000000000 -0800
>> +++ xfs-cmds/xfstests/189 2008-11-21 13:42:48.000000000 -0800
>> @@ -188,8 +188,8 @@
>> _need_to_be_root
>> _require_scratch
>>
>> -unset SCRATCH_OPTIONS
>> -unset MOUNT_OPTIONS
>> +unset SCRATCH_RTDEV
>> +unset SCRATCH_LOGDEV
>>
>> _scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>
> ---end quoted text---
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: couple small xfstest patches
2008-12-22 14:55 ` Eric Sandeen
@ 2008-12-29 11:37 ` Christoph Hellwig
0 siblings, 0 replies; 5+ messages in thread
From: Christoph Hellwig @ 2008-12-29 11:37 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Christoph Hellwig, xfs
On Mon, Dec 22, 2008 at 08:55:20AM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Fri, Nov 21, 2008 at 01:45:23PM -0800, Matthew Kent wrote:
> >> * 189 fails with external devices
> >> * add a unified diff output option, find it easier on the eyes ;)
> >
> > Thanks, I'll put these into my queue. Question to the list: any
> > arguments against just making unified diffs the default for xfsqa
> > output?
>
> none here; I run patched that way already.
Given that no one else complained I'll make it the default.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-12-29 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-21 21:45 couple small xfstest patches Matthew Kent
2008-11-21 22:17 ` Matthew Kent
2008-12-22 13:08 ` Christoph Hellwig
2008-12-22 14:55 ` Eric Sandeen
2008-12-29 11:37 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox