* [PATCH] handle unaligned data in xfs_bmbt_disk_get_all
@ 2008-12-22 14:59 Christoph Hellwig
2008-12-23 0:45 ` Lachlan McIlroy
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2008-12-22 14:59 UTC (permalink / raw)
To: xfs
In libxfs xfs_bmbt_disk_get_all needs to handle unaligned data and thus
has been updated to use get_unaligned_be64. In kernelspace we don't strictly
need it as the routine is only used for tracing and xfsidbg, but let's keep
the two implementations in sync.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/xfs/xfs_bmap_btree.c
--- xfs.orig/fs/xfs/xfs_bmap_btree.c 2008-12-19 15:02:53.998907997 +0100
+++ xfs/fs/xfs/xfs_bmap_btree.c 2008-12-22 14:43:41.507247175 +0100
@@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all(
xfs_bmbt_rec_t *r,
xfs_bmbt_irec_t *s)
{
- __xfs_bmbt_get_all(be64_to_cpu(r->l0), be64_to_cpu(r->l1), s);
+ __xfs_bmbt_get_all(get_unaligned_be64(&r->l0),
+ get_unaligned_be64(&r->l1), s);
}
/*
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] handle unaligned data in xfs_bmbt_disk_get_all
2008-12-22 14:59 [PATCH] handle unaligned data in xfs_bmbt_disk_get_all Christoph Hellwig
@ 2008-12-23 0:45 ` Lachlan McIlroy
0 siblings, 0 replies; 2+ messages in thread
From: Lachlan McIlroy @ 2008-12-23 0:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
Looks good.
Christoph Hellwig wrote:
> In libxfs xfs_bmbt_disk_get_all needs to handle unaligned data and thus
> has been updated to use get_unaligned_be64. In kernelspace we don't strictly
> need it as the routine is only used for tracing and xfsidbg, but let's keep
> the two implementations in sync.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/fs/xfs/xfs_bmap_btree.c
> --- xfs.orig/fs/xfs/xfs_bmap_btree.c 2008-12-19 15:02:53.998907997 +0100
> +++ xfs/fs/xfs/xfs_bmap_btree.c 2008-12-22 14:43:41.507247175 +0100
> @@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all(
> xfs_bmbt_rec_t *r,
> xfs_bmbt_irec_t *s)
> {
> - __xfs_bmbt_get_all(be64_to_cpu(r->l0), be64_to_cpu(r->l1), s);
> + __xfs_bmbt_get_all(get_unaligned_be64(&r->l0),
> + get_unaligned_be64(&r->l1), s);
> }
>
> /*
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-23 0:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-22 14:59 [PATCH] handle unaligned data in xfs_bmbt_disk_get_all Christoph Hellwig
2008-12-23 0:45 ` Lachlan McIlroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox