From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] xfs_repair: allow filesystems with a single AG
Date: Thu, 25 Dec 2008 11:54:00 -0600 [thread overview]
Message-ID: <4953C8B8.4010500@sandeen.net> (raw)
In-Reply-To: <20081224231901.GA652@infradead.org>
Christoph Hellwig wrote:
> Currently xfs_repair bails out on a filesystem with just a single AG.
> But that's a perfectly valid configureation, so we should allow it.
>
> Skip the geomery validation because we simply can't do it if we don't
> have a secondary SB, and make sure to take the internal log into account
> when guestimating the first inode cluster.
>
> I'll also cook up a testcase for repair on single AG filesystems.
While I think we should certainly allow this, what's the worst-case
scenario for a corrupted superblock when we can't validate it and
continue with repair?
I wonder if something like
# xfs_repair --allow-single-sb
should be required, with some man page docs suggesting a run with -n
first etc to be sure that garbled geometry doesn't trash the whole thing...?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2008-12-25 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-24 23:19 [PATCH, RFC] xfs_repair: allow filesystems with a single AG Christoph Hellwig
2008-12-25 17:54 ` Eric Sandeen [this message]
2009-01-04 16:48 ` Christoph Hellwig
2009-01-05 3:11 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4953C8B8.4010500@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox