public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsprogs: make install-qa should only install additional headers
Date: Thu, 01 Jan 2009 11:55:45 -0600	[thread overview]
Message-ID: <495D03A1.6090307@sandeen.net> (raw)
In-Reply-To: <20081230174152.GA18469@infradead.org>

Christoph Hellwig wrote:
> make install-qa should only install the headers a normal install-dev
> doesn't install instead of repeating the whole game.
> 
> That way the additional headers for xfsqa can be installed manually
> while using dpkg / rpm for the normal package. 

This seems mostly ok, but "install-qa" sort of sounds like it should
install the headers you need for qa and it doesn't, it only (now)
installs the extras right...?  By itself it's kind of a useless target
without also running install-dev isn't it?

To be correct, I think install-qa should have install-dev as a prereq.

Maybe do that, and add a new install-qa-only target? :)

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: xfsprogs/Makefile
> ===================================================================
> --- xfsprogs/Makefile	2008-12-30 13:03:06.000000000 +0000
> +++ xfsprogs/Makefile	2008-12-30 13:03:15.000000000 +0000
> @@ -76,7 +76,7 @@
>  
>  install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
>  
> -install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
> +install-qa: default $(addsuffix -install-qa,$(SUBDIRS))
>  
>  %-install:
>  	$(MAKE) -C $* install
> Index: xfsprogs/include/Makefile
> ===================================================================
> --- xfsprogs/include/Makefile	2008-12-30 13:02:05.000000000 +0000
> +++ xfsprogs/include/Makefile	2008-12-30 13:02:31.000000000 +0000
> @@ -54,5 +54,5 @@
>  	$(INSTALL) -m 755 -d $(DK_INC_DIR)
>  	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
>  
> -install-qa: install-dev
> +install-qa: default
>  	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)
> Index: xfsprogs/libdisk/Makefile
> ===================================================================
> --- xfsprogs/libdisk/Makefile	2008-12-30 13:00:53.000000000 +0000
> +++ xfsprogs/libdisk/Makefile	2008-12-30 13:01:39.000000000 +0000
> @@ -29,4 +29,4 @@
>  install-dev: default
>  	$(INSTALL_LTLIB_STATIC)
>  
> -install-qa: install-dev
> +install-qa: default
> Index: xfsprogs/libhandle/Makefile
> ===================================================================
> --- xfsprogs/libhandle/Makefile	2008-12-30 13:01:09.000000000 +0000
> +++ xfsprogs/libhandle/Makefile	2008-12-30 13:01:34.000000000 +0000
> @@ -22,4 +22,4 @@
>  install-dev: default
>  	$(INSTALL_LTLIB_DEV)
>  
> -install-qa: install-dev
> +install-qa: default
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-01-01 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30 17:41 [PATCH] xfsprogs: make install-qa should only install additional headers Christoph Hellwig
2009-01-01 17:55 ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495D03A1.6090307@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox