public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] attr: fix include/ symlink creation (again)
@ 2009-01-08 19:07 Eric Sandeen
  2009-01-09  7:20 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2009-01-08 19:07 UTC (permalink / raw)
  To: xfs mailing list

We need the "default" target first, otherwise a simple "make -C include"
only ran the $(INCDIR) target, missing disk, and failures ensued.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/include/Makefile b/include/Makefile
index 3fde1fc..a645251 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -11,11 +11,11 @@ HFILES = $(INST_HFILES) misc.h walk_tree.h
 LSRCFILES = builddefs.in buildmacros buildrules config.h.in
 LDIRT = $(INCDIR)
 
+default: $(INCDIR)
+
 $(INCDIR):
 	$(LN_S) . $@
 
-default: $(INCDIR)
-
 include $(BUILDRULES)
 
 install-dev: default


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] attr: fix include/ symlink creation (again)
  2009-01-08 19:07 [PATCH] attr: fix include/ symlink creation (again) Eric Sandeen
@ 2009-01-09  7:20 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2009-01-09  7:20 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs mailing list

On Thu, Jan 08, 2009 at 01:07:35PM -0600, Eric Sandeen wrote:
> We need the "default" target first, otherwise a simple "make -C include"
> only ran the $(INCDIR) target, missing disk, and failures ensued.

Looks good, too.  I wonder why attr uses INCDIR instead of just spelling
out the name like all other packages..

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-01-09  7:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-08 19:07 [PATCH] attr: fix include/ symlink creation (again) Eric Sandeen
2009-01-09  7:20 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox