[PATCH] xfstests: only run 197 on 32-bit machines

[PATCH] xfstests: only run 197 on 32-bit machines

[Eric Sandeen]

Don't run test 197 on 64-bit machines

If it always passes on 64 bits, this gives a false
sense of security.  Make it obvious.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
--

diff --git a/197 b/197
index 4c81941..f77bfa2 100644
--- a/197
+++ b/197
@@ -37,6 +37,10 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fs xfs
 _supported_os Linux
 
+bitsperlong=`src/feature -w`
+if [ "$bitsperlong" -ne 32 ]; then
+	_notrun "This test is only valid on 32 bit machines"
+fi
 
 mkdir $TEST_DIR/ttt
 for n in {1..168}; do


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: only run 197 on 32-bit machines

[Felix Blyakher]

On Jan 14, 2009, at 8:08 PM, Eric Sandeen wrote:

> Don't run test 197 on 64-bit machines
>
> If it always passes on 64 bits, this gives a false
> sense of security.  Make it obvious.

Sounds reasonable.

>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Signed-off-by: Felix Blyakher <felixb@sgi.com>

> --
>
> diff --git a/197 b/197
> index 4c81941..f77bfa2 100644
> --- a/197
> +++ b/197
> @@ -37,6 +37,10 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  _supported_fs xfs
>  _supported_os Linux
>
> +bitsperlong=`src/feature -w`
> +if [ "$bitsperlong" -ne 32 ]; then
> +	_notrun "This test is only valid on 32 bit machines"
> +fi
>
>  mkdir $TEST_DIR/ttt
>  for n in {1..168}; do
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: only run 197 on 32-bit machines

[Christoph Hellwig]

On Wed, Jan 14, 2009 at 08:08:04PM -0600, Eric Sandeen wrote:
> Don't run test 197 on 64-bit machines
> 
> If it always passes on 64 bits, this gives a false
> sense of security.  Make it obvious.

I don't think it matters, but your patch looks correct and if it helps
you in some way..


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: only run 197 on 32-bit machines

[Eric Sandeen]

Christoph Hellwig wrote:
> On Wed, Jan 14, 2009 at 08:08:04PM -0600, Eric Sandeen wrote:
>> Don't run test 197 on 64-bit machines
>>
>> If it always passes on 64 bits, this gives a false
>> sense of security.  Make it obvious.
> 
> I don't think it matters, but your patch looks correct and if it helps
> you in some way..
> 
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 

thanks

I only wanted to put it in because I was looking at fedora, wanted to
test it against this bug, ran it, it passed, and *then* I remembered
that it'd only fail on 32-bit, and my test (on that hardware) wasn't
really valid.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs