public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: only run 197 on 32-bit machines
Date: Sun, 18 Jan 2009 13:27:23 -0600	[thread overview]
Message-ID: <4973829B.6000008@sandeen.net> (raw)
In-Reply-To: <20090118171723.GA12645@infradead.org>

Christoph Hellwig wrote:
> On Wed, Jan 14, 2009 at 08:08:04PM -0600, Eric Sandeen wrote:
>> Don't run test 197 on 64-bit machines
>>
>> If it always passes on 64 bits, this gives a false
>> sense of security.  Make it obvious.
> 
> I don't think it matters, but your patch looks correct and if it helps
> you in some way..
> 
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 

thanks

I only wanted to put it in because I was looking at fedora, wanted to
test it against this bug, ran it, it passed, and *then* I remembered
that it'd only fail on 32-bit, and my test (on that hardware) wasn't
really valid.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2009-01-18 19:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15  2:08 [PATCH] xfstests: only run 197 on 32-bit machines Eric Sandeen
2009-01-15  5:14 ` Felix Blyakher
2009-01-18 17:17 ` Christoph Hellwig
2009-01-18 19:27   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4973829B.6000008@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox