From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id n0IJRPPj020616 for ; Sun, 18 Jan 2009 13:27:25 -0600 Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 96C5D9AC96 for ; Sun, 18 Jan 2009 11:27:24 -0800 (PST) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id 7Cf7SZ43Ux2BoqTD for ; Sun, 18 Jan 2009 11:27:24 -0800 (PST) Message-ID: <4973829B.6000008@sandeen.net> Date: Sun, 18 Jan 2009 13:27:23 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: only run 197 on 32-bit machines References: <496E9A84.2060304@sandeen.net> <20090118171723.GA12645@infradead.org> In-Reply-To: <20090118171723.GA12645@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs-oss Christoph Hellwig wrote: > On Wed, Jan 14, 2009 at 08:08:04PM -0600, Eric Sandeen wrote: >> Don't run test 197 on 64-bit machines >> >> If it always passes on 64 bits, this gives a false >> sense of security. Make it obvious. > > I don't think it matters, but your patch looks correct and if it helps > you in some way.. > > > Reviewed-by: Christoph Hellwig > thanks I only wanted to put it in because I was looking at fedora, wanted to test it against this bug, ran it, it passed, and *then* I remembered that it'd only fail on 32-bit, and my test (on that hardware) wasn't really valid. -Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs