From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: fix comment in bmap.c
Date: Sat, 24 Jan 2009 09:10:54 -0600 [thread overview]
Message-ID: <497B2F7E.9040501@sandeen.net> (raw)
In-Reply-To: <20090124143938.GA31680@lst.de>
Christoph Hellwig wrote:
> Based on a patch from Tomasz Majkowski <moosh009@gmail.com> in bugzilla
> #785.
>
Heh, I can ACK this one :)
-Eric
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfsprogs-dev/io/bmap.c
> ===================================================================
> --- xfsprogs-dev.orig/io/bmap.c 2009-01-24 15:36:56.780113315 +0100
> +++ xfsprogs-dev/io/bmap.c 2009-01-24 15:37:17.875168142 +0100
> @@ -140,7 +140,7 @@ bmap_f(
> }
> }
>
> - map_size = nflag ? nflag+2 : 32; /* initial guess - 256 */
> + map_size = nflag ? nflag+2 : 32; /* initial guess - 32 */
> map = malloc(map_size*sizeof(*map));
> if (map == NULL) {
> fprintf(stderr, _("%s: malloc of %d bytes failed.\n"),
> @@ -151,7 +151,7 @@ bmap_f(
>
>
> /* Try the xfsctl(XFS_IOC_GETBMAPX) for the number of extents specified
> - * by nflag, or the initial guess number of extents (256).
> + * by nflag, or the initial guess number of extents (32).
> *
> * If there are more extents than we guessed, use xfsctl
> * (XFS_IOC_FSGETXATTR[A]) to get the extent count, realloc some more
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-01-24 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 14:39 [PATCH] xfs_io: fix comment in bmap.c Christoph Hellwig
2009-01-24 15:10 ` Eric Sandeen [this message]
2009-01-24 17:59 ` Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497B2F7E.9040501@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox