public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfsprogs spec file update
@ 2009-01-24  6:14 Nathan Scott
  2009-01-25  5:00 ` Christoph Hellwig
  2009-01-25 14:21 ` Eric Sandeen
  0 siblings, 2 replies; 3+ messages in thread
From: Nathan Scott @ 2009-01-24  6:14 UTC (permalink / raw)
  To: xfs

Since binaries have moved between xfsprogs and xfsdump packages
in version 3.0.0, we need to fix the dependencies in the rpm
specfiles, else rpm will complain.

While in there, remove xfs-cmds Provides/Obsoletes lines, there
is no way anyone is ever going to be requiring those anymore (no
real-world upgrade path having such old skool SGI-released rpms).

diff --git a/build/rpm/xfsprogs.spec.in b/build/rpm/xfsprogs.spec.in
index 2826a37..cf61225 100644
--- a/build/rpm/xfsprogs.spec.in
+++ b/build/rpm/xfsprogs.spec.in
@@ -5,10 +5,8 @@ Release: @pkg_release@
 Distribution: @pkg_distribution@
 Packager: Silicon Graphics, Inc. <http://www.sgi.com/>
 BuildRoot: @build_root@ 
-Provides: xfs-cmds
-Obsoletes: xfs-cmds
 Prereq: /sbin/ldconfig
-Conflicts: xfsdump < 2.0.0
+Conflicts: xfsdump < 3.0.0
 Source: @pkg_name@-@pkg_version@.src.tar.gz
 License: GPL
 Vendor: Silicon Graphics, Inc.
@@ -32,8 +30,8 @@ with the IRIX version of XFS.
 %package devel
 Summary: XFS filesystem-specific static libraries and headers.
 Group: Development/Libraries
-Requires: @pkg_name@ >= 2.0.0
-Conflicts: @pkg_name@ < 2.0.0
+Requires: @pkg_name@ >= 3.0.0
+Conflicts: @pkg_name@ < 3.0.0
 
 %description devel
 xfsprogs-devel contains the libraries and header files needed to


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs spec file update
  2009-01-24  6:14 [PATCH] xfsprogs spec file update Nathan Scott
@ 2009-01-25  5:00 ` Christoph Hellwig
  2009-01-25 14:21 ` Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2009-01-25  5:00 UTC (permalink / raw)
  To: Nathan Scott; +Cc: xfs

On Sat, Jan 24, 2009 at 05:14:27PM +1100, Nathan Scott wrote:
> Since binaries have moved between xfsprogs and xfsdump packages
> in version 3.0.0, we need to fix the dependencies in the rpm
> specfiles, else rpm will complain.
> 
> While in there, remove xfs-cmds Provides/Obsoletes lines, there
> is no way anyone is ever going to be requiring those anymore (no
> real-world upgrade path having such old skool SGI-released rpms).

Looks good to me, even without any real uptodate rpm knowledge..

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfsprogs spec file update
  2009-01-24  6:14 [PATCH] xfsprogs spec file update Nathan Scott
  2009-01-25  5:00 ` Christoph Hellwig
@ 2009-01-25 14:21 ` Eric Sandeen
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2009-01-25 14:21 UTC (permalink / raw)
  To: Nathan Scott; +Cc: xfs

Nathan Scott wrote:
> Since binaries have moved between xfsprogs and xfsdump packages
> in version 3.0.0, we need to fix the dependencies in the rpm
> specfiles, else rpm will complain.
> 
> While in there, remove xfs-cmds Provides/Obsoletes lines, there
> is no way anyone is ever going to be requiring those anymore (no
> real-world upgrade path having such old skool SGI-released rpms).

Seems fine to me, though before I update Fedora to the next version I'll
probably pass the notion past the true RPM gurus to be sure :)

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

> diff --git a/build/rpm/xfsprogs.spec.in b/build/rpm/xfsprogs.spec.in
> index 2826a37..cf61225 100644
> --- a/build/rpm/xfsprogs.spec.in
> +++ b/build/rpm/xfsprogs.spec.in
> @@ -5,10 +5,8 @@ Release: @pkg_release@
>  Distribution: @pkg_distribution@
>  Packager: Silicon Graphics, Inc. <http://www.sgi.com/>
>  BuildRoot: @build_root@ 
> -Provides: xfs-cmds
> -Obsoletes: xfs-cmds
>  Prereq: /sbin/ldconfig
> -Conflicts: xfsdump < 2.0.0
> +Conflicts: xfsdump < 3.0.0
>  Source: @pkg_name@-@pkg_version@.src.tar.gz
>  License: GPL
>  Vendor: Silicon Graphics, Inc.
> @@ -32,8 +30,8 @@ with the IRIX version of XFS.
>  %package devel
>  Summary: XFS filesystem-specific static libraries and headers.
>  Group: Development/Libraries
> -Requires: @pkg_name@ >= 2.0.0
> -Conflicts: @pkg_name@ < 2.0.0
> +Requires: @pkg_name@ >= 3.0.0
> +Conflicts: @pkg_name@ < 3.0.0
>  
>  %description devel
>  xfsprogs-devel contains the libraries and header files needed to
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-01-25 14:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-24  6:14 [PATCH] xfsprogs spec file update Nathan Scott
2009-01-25  5:00 ` Christoph Hellwig
2009-01-25 14:21 ` Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox