From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Nathan Scott <nscott@aconex.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] remove remaining unused-but-installed headers
Date: Thu, 29 Jan 2009 17:39:53 -0500 [thread overview]
Message-ID: <49823039.7090203@sandeen.net> (raw)
In-Reply-To: <20090129223700.GA3772@infradead.org>
Christoph Hellwig wrote:
> On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
>> diff --git a/include/Makefile b/include/Makefile
>> index 0403536..07076cc 100644
>> --- a/include/Makefile
>> +++ b/include/Makefile
>> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
>> xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
>> xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
>> xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
>> - xfs_trans.h xfs_trans_space.h xfs_types.h
>> + xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
>
> dfrag is not needed anymore because we moved fsr to xfsprogs.
>
>> - $(INSTALL) -m 755 -d $(DK_INC_DIR)
>> - $(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
>
> I think as some point libdisk was supposed to be a library others
> could use. I don't mind if we make it private as it should be fold
> into the libvolume_id/libblkid successor in util-linux one day.
I don't know if there are plans to get the stripe size stuff into the
successor (what we have is kinda hacky) but maybe we should start that
conversation.
Keeping private should be fine, though.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-01-29 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 11:24 [PATCH] remove remaining unused-but-installed headers Nathan Scott
2009-01-29 22:37 ` Christoph Hellwig
2009-01-29 22:39 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49823039.7090203@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=nscott@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox