[PATCH] remove remaining unused-but-installed headers

[PATCH] remove remaining unused-but-installed headers

[Nathan Scott]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

Looks like Barry missed a few headers... or at least, I can't
find anything outside xfsprogs that uses these anymore.  But,
no sane reason we should be installing these in /usr/include/
disk on everyone's systems - build can get 'em out of its own
include/ directory already.

cheers.

--
Nathan

[-- Attachment #2: disk.patch --]
[-- Type: text/x-patch, Size: 988 bytes --]

diff --git a/include/Makefile b/include/Makefile
index 0403536..07076cc 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
 	xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
 	xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
 	xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
-	xfs_trans.h xfs_trans_space.h xfs_types.h
+	xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
 
-HFILES = handle.h jdm.h xqm.h xfs.h xfs_dfrag.h xfs_fs.h
+HFILES = handle.h jdm.h xqm.h xfs.h xfs_fs.h
 HFILES += $(PKG_PLATFORM).h
 PHFILES = darwin.h freebsd.h irix.h linux.h
 DKHFILES = volume.h fstyp.h dvh.h
@@ -51,8 +51,6 @@ install-dev: default
 	$(INSTALL) -m 755 -d $(PKG_INC_DIR)
 	$(INSTALL) -m 644 $(HFILES) $(PKG_INC_DIR)
 	$(INSTALL) -m 644 platform_defs.h $(PKG_INC_DIR)
-	$(INSTALL) -m 755 -d $(DK_INC_DIR)
-	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
 
 install-qa: install-dev
 	$(INSTALL) -m 644 $(QAHFILES) $(PKG_INC_DIR)

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] remove remaining unused-but-installed headers

[Christoph Hellwig]

On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
> diff --git a/include/Makefile b/include/Makefile
> index 0403536..07076cc 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
>  	xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
>  	xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
>  	xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
> -	xfs_trans.h xfs_trans_space.h xfs_types.h
> +	xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h

dfrag is not needed anymore because we moved fsr to xfsprogs.

> -	$(INSTALL) -m 755 -d $(DK_INC_DIR)
> -	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)

I think as some point libdisk was supposed to be a library others
could use.  I don't mind if we make it private as it should be fold
into the libvolume_id/libblkid successor in util-linux one day.


So all over this look good to me.

Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] remove remaining unused-but-installed headers

[Eric Sandeen]

Christoph Hellwig wrote:
> On Wed, Jan 28, 2009 at 10:24:03PM +1100, Nathan Scott wrote:
>> diff --git a/include/Makefile b/include/Makefile
>> index 0403536..07076cc 100644
>> --- a/include/Makefile
>> +++ b/include/Makefile
>> @@ -29,9 +29,9 @@ QAHFILES = libxfs.h libxlog.h \
>>  	xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
>>  	xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
>>  	xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h \
>> -	xfs_trans.h xfs_trans_space.h xfs_types.h
>> +	xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
> 
> dfrag is not needed anymore because we moved fsr to xfsprogs.
> 
>> -	$(INSTALL) -m 755 -d $(DK_INC_DIR)
>> -	$(INSTALL) -m 644 $(DKHFILES) $(DK_INC_DIR)
> 
> I think as some point libdisk was supposed to be a library others
> could use.  I don't mind if we make it private as it should be fold
> into the libvolume_id/libblkid successor in util-linux one day.

I don't know if there are plans to get the stripe size stuff into the
successor (what we have is kinda hacky) but maybe we should start that
conversation.

Keeping private should be fine, though.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs