From: Eric Sandeen <sandeen@sandeen.net>
To: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] build: Explict libtool tag. Preserve CFLAGS/CPPFLAGS.
Date: Sun, 01 Feb 2009 16:05:05 -0600 [thread overview]
Message-ID: <49861C91.2080106@sandeen.net> (raw)
In-Reply-To: <1233523650-203120-1-git-send-email-arekm@maven.pl>
Arkadiusz Miśkiewicz wrote:
> Use explict libtool CC tag (sometimes libtool can't decide what tag is
> correct one if omited).
Seems good to me. I'll push this on the kernel.org repo, thanks.
(This is against xfstests, based on irc conversation) :)
-Eric
> Preserve CFLAGS/CPPFLAGS to allow:
> CPPFLAGS="-I$HOME/here-is-xfsprogs-installed/include" \
> LDFLAGS="-L$HOME/here-is-xfsprogs-installed/lib" \
> ./configure ...
>
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
> ---
> include/builddefs.in | 4 +++-
> include/buildmacros | 4 ++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/builddefs.in b/include/builddefs.in
> index d855c89..636f632 100644
> --- a/include/builddefs.in
> +++ b/include/builddefs.in
> @@ -11,6 +11,8 @@ DEBUG = @debug_build@
> OPTIMIZER = @opt_build@
> MALLOCLIB = @malloc_lib@
> LOADERFLAGS = @LDFLAGS@
> +CFLAGS = @CFLAGS@
> +CPPFLAGS = @CPPFLAGS@
>
> LIBXFS = @libxfs@
> LIBACL = @libacl@
> @@ -75,7 +77,7 @@ ifeq ($(PKG_PLATFORM),freebsd)
> DEPENDFLAGS = -D__FreeBSD__
> endif
>
> -GCFLAGS = $(OPTIMIZER) $(DEBUG) \
> +GCFLAGS = $(OPTIMIZER) $(DEBUG) $(CPPFLAGS) \
> -I$(TOPDIR)/include -DVERSION=\"$(PKG_VERSION)\"
>
> # Global, Platform, Local CFLAGS
> diff --git a/include/buildmacros b/include/buildmacros
> index 801bcb6..276d2c8 100644
> --- a/include/buildmacros
> +++ b/include/buildmacros
> @@ -41,10 +41,10 @@ LIBNAME = $(basename $(LTLIBRARY))
> LTOBJECTS = $(OBJECTS:.o=.lo)
> LTVERSION = $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
>
> -LTLINK = $(LIBTOOL) --mode=link $(CC)
> +LTLINK = $(LIBTOOL) --tag=CC --mode=link $(CC)
> LTEXEC = $(LIBTOOL) --mode=execute
> LTINSTALL = $(LIBTOOL) --mode=install $(INSTALL)
> -LTCOMPILE = $(LIBTOOL) --mode=compile $(CCF)
> +LTCOMPILE = $(LIBTOOL) --tag=CC --mode=compile $(CCF)
>
> ifeq ($(ENABLE_SHARED),yes)
> LTLDFLAGS += -rpath $(PKG_LIB_DIR)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-02-01 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 21:27 [PATCH] build: Explict libtool tag. Preserve CFLAGS/CPPFLAGS Arkadiusz Miśkiewicz
2009-02-01 22:05 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49861C91.2080106@sandeen.net \
--to=sandeen@sandeen.net \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox