From: Eric Sandeen <sandeen@sandeen.net>
To: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Fix *FLAGS passing and dependencies.
Date: Mon, 02 Feb 2009 14:16:10 -0600 [thread overview]
Message-ID: <4987548A.1070809@sandeen.net> (raw)
In-Reply-To: <1233565776-563-1-git-send-email-arekm@maven.pl>
Arkadiusz Miśkiewicz wrote:
> Pass *FLAGS in some targets.
>
> Drop LIBHANDLE, LIBATTR and LIBACL from deps since there are in form
> "-llibrary".
ugh, weird.
>
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>
Looks fine to me. I'll merge it to the kernel.org repo.
-Eric
> ---
> src/Makefile | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/Makefile b/src/Makefile
> index ad4c204..634e1b3 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -58,10 +58,10 @@ genhashnames: genhashnames.o
> nametest: nametest.o $(LIBTEST)
> $(LINKTEST) $(LIBTEST) $(LDLIBS)
>
> -bstat: bstat.o $(LIBHANDLE)
> +bstat: bstat.o
> $(LINKTEST) $(LIBHANDLE) $(LDLIBS)
>
> -t_immutable: t_immutable.o $(LIBHANDLE) $(LIBACL)
> +t_immutable: t_immutable.o
> $(LINKTEST) $(LIBACL) $(LIBHANDLE) $(LDLIBS)
>
> loggen: loggen.o
> @@ -82,17 +82,17 @@ multi_open_unlink: multi_open_unlink.o
> #scaleread: scaleread.o $(LDLIBS)
> # $(LINKTEST)
>
> -acl_get: acl_get.o $(LIBACL) $(LIBATTR)
> +acl_get: acl_get.o
> $(LINKTEST) $(LIBACL) $(LIBATTR) $(LDLIBS)
>
> -dmiperf: dmiperf.o $(LIBATTR)
> +dmiperf: dmiperf.o
> $(LINKTEST) $(LIBATTR) $(LDLIBS)
>
> preallo_rw_pattern_reader:
> - $(CC) -DREAD iopat.c -o preallo_rw_pattern_reader
> + $(CC) $(GCFLAGS) $(LDFLAGS) -DREAD iopat.c -o preallo_rw_pattern_reader
>
> preallo_rw_pattern_writer:
> - $(CC) -DWRITE iopat.c -o preallo_rw_pattern_writer
> + $(CC) $(GCFLAGS) $(LDFLAGS) -DWRITE iopat.c -o preallo_rw_pattern_writer
>
> ftrunc: ftrunc.o
> $(LINKTEST)
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-02 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 9:09 [PATCH] xfstests: Fix *FLAGS passing and dependencies Arkadiusz Miśkiewicz
2009-02-02 20:16 ` Eric Sandeen [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-02 9:08 Arkadiusz Miśkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987548A.1070809@sandeen.net \
--to=sandeen@sandeen.net \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox