From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] test 199: test features2 fixup for the regular case, too
Date: Sat, 14 Feb 2009 14:11:40 -0600 [thread overview]
Message-ID: <4997257C.2090303@sandeen.net> (raw)
In-Reply-To: <20090214164024.GB19813@infradead.org>
Christoph Hellwig wrote:
> Eric Sandeen noted that we should not only test the mount ro first, then
> remount rw case in 199 but also the regular mount rw case.
>
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/199
> ===================================================================
> --- xfstests-dev.orig/199 2009-02-14 15:08:08.000000000 +0000
> +++ xfstests-dev/199 2009-02-14 15:10:53.000000000 +0000
> @@ -1,8 +1,10 @@
> #! /bin/sh
> # FS QA Test No. 199
> #
> -# Check that a filesystem first mounted read-only and then remounted
> -# performs the features2 fixup properly.
> +# Check that the features2 localtion fixups work correctly. We check both
^^^ typo (location)
> +# a regualar read-write mount of a filesystem and the case where the
^^^ typo (regular)
With those fixes, ACK, thanks!
-Eric
> +# filesystem is first mounted read-only and then later remounted read-write,
> +# which is the usual case for the root filesystem.
> #
> #-----------------------------------------------------------------------
> # Copyright (c) 2008 Christoph Hellwig.
> @@ -51,8 +53,20 @@
> echo "Clearing features2:"
> xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
>
> +_scratch_mount
> +umount $SCRATCH_MNT
> +echo "Features 2 after mount rw:"
> +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2'
> +
> +#
> +# Clear the normal flags again for the second rount.
> +#
> +echo "Clearing features2:"
> +xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
> +
> #
> # And print the flags after a mount ro and remount rw
> +#
> _scratch_mount -o ro
> _scratch_mount -o remount,rw
> umount $SCRATCH_MNT
> Index: xfstests-dev/199.out
> ===================================================================
> --- xfstests-dev.orig/199.out 2009-02-14 15:11:18.000000000 +0000
> +++ xfstests-dev/199.out 2009-02-14 15:11:26.000000000 +0000
> @@ -4,6 +4,10 @@
> bad_features2 = 0x8
> Clearing features2:
> features2 = 0
> +Features 2 after mount rw:
> +features2 = 0x8
> +Clearing features2:
> +features2 = 0
> Features 2 after mount ro and remount rw:
> features2 = 0x8
> *** done
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-02-14 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 16:40 [PATCH] test 199: test features2 fixup for the regular case, too Christoph Hellwig
2009-02-14 20:11 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4997257C.2090303@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox