From: Eric Sandeen <sandeen@sandeen.net>
To: Zdenek Prikryl <zprikryl@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: libattr - severe memory leaks from attr_copy_file()
Date: Thu, 19 Feb 2009 10:31:12 -0600 [thread overview]
Message-ID: <499D8950.9030708@sandeen.net> (raw)
In-Reply-To: <499D0471.6000600@redhat.com>
Zdenek Prikryl wrote:
>> And the variable, text, is assigned straight away before any use,
>> so I missed where the problem is.
>>
>> --Tim
>
> The memory leak is really there. Look:
>
> 54 attr_parse_attr_conf(struct error_context *ctx)
> ...
> 66 repeat:
> 67 text = malloc(size_guess + 1);
> 68 if (!text)
> 69 goto fail;
> 70
> 71 if ((file = fopen(ATTR_CONF, "r")) == NULL) {
> 72 if (errno == ENOENT)
> 73 return 0;
> 74 goto fail;
> 75 }
>
> Let's say that malloc() on the line 67 success, so we have text != NULL. Then,
> fopen() on the line 71 fails and errno == ENOENT. In that case
> attr_parse_attr_conf() simply returns 0, but text isn't freed. That's the point,
> where memory leaks arise. I rewrote the patch, so now is more simpler.
The patch you attached looks good to me, thanks.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-02-19 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 7:04 libattr - severe memory leaks from attr_copy_file() Zdenek Prikryl
2009-02-19 16:31 ` Eric Sandeen [this message]
2009-02-20 0:33 ` Timothy Shimmin
-- strict thread matches above, loose matches on Subject: below --
2009-02-17 11:50 Zdenek Prikryl
2009-02-17 12:04 ` Arkadiusz Miskiewicz
2009-02-18 7:08 ` Timothy Shimmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=499D8950.9030708@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
--cc=zprikryl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox