From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andras Korn <korn-sgi.com@chardonnay.math.bme.hu>, xfs@oss.sgi.com
Subject: Re: xfs: prevent kernel crash due to corrupted inode log format
Date: Tue, 03 Mar 2009 10:28:37 -0600 [thread overview]
Message-ID: <49AD5AB5.9050604@sandeen.net> (raw)
In-Reply-To: <20090215191344.GA16706@infradead.org>
Christoph Hellwig wrote:
> Andras Korn reported an oops on log replay causes by a corrupted
> xfs_inode_log_format_t passing a 0 size to kmem_zalloc. This patch handles
> to small or too large numbers of log regions gracefully by rejecting the
> log replay with a useful error message.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Andras Korn <korn-sgi.com@chardonnay.math.bme.hu>
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfs/fs/xfs/xfs_log_recover.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log_recover.c 2009-02-12 19:00:29.056944584 +0100
> +++ xfs/fs/xfs/xfs_log_recover.c 2009-02-15 20:07:56.568971792 +0100
> @@ -1455,10 +1455,19 @@ xlog_recover_add_to_trans(
> item = item->ri_prev;
>
> if (item->ri_total == 0) { /* first region to be added */
> - item->ri_total = in_f->ilf_size;
> - ASSERT(item->ri_total <= XLOG_MAX_REGIONS_IN_ITEM);
> - item->ri_buf = kmem_zalloc((item->ri_total *
> - sizeof(xfs_log_iovec_t)), KM_SLEEP);
> + if (in_f->ilf_size == 0 ||
> + in_f->ilf_size > XLOG_MAX_REGIONS_IN_ITEM) {
> + xlog_warn(
> + "XFS: bad number of regions (%d) in inode log format",
> + in_f->ilf_size);
> + ASSERT(0);
> + return XFS_ERROR(EIO);
> + }
> +
> + item->ri_total = in_f->ilf_size;
> + item->ri_buf =
> + kmem_zalloc(item->ri_total * sizeof(xfs_log_iovec_t),
> + KM_SLEEP);
> }
> ASSERT(item->ri_total > item->ri_cnt);
> /* Description region is ri_buf[0] */
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-03-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 19:13 xfs: prevent kernel crash due to corrupted inode log format Christoph Hellwig
2009-02-16 20:35 ` Arkadiusz Miskiewicz
2009-02-17 9:31 ` Christoph Hellwig
2009-03-03 16:28 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AD5AB5.9050604@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=korn-sgi.com@chardonnay.math.bme.hu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox