From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: tarballs generated by Makepkgs
Date: Sun, 22 Mar 2009 14:22:08 -0500 [thread overview]
Message-ID: <49C68FE0.4030501@sandeen.net> (raw)
In-Reply-To: <20090224184252.GA28007@infradead.org>
Christoph Hellwig wrote:
> On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
>> currently Makepkgs generats the source tarball as
>> package-version.src.tar.gz, which is not what we used for recent
>> releases and not what most other open source packages do. I'd like to
>> change it to package-version.tar.gz, but that currently collides with
>> the binary tar packages.
>>
>> Does anyone still need those binary tar packages? If yes we should
>> rename them, too or otherwise just remove them.
>
> This would be the easiest way, renaming the binary packages to
> xfsprogs-$ver.bin.tar.gz and the source to the expected
> xfsprogs-$ver.tar.gz. Same patch would also go into xfsdump and dmapi.
>
Yes, this looks good. it always bugged me the way it was ;)
Missed this for review based on no [PATCH] ;)
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
(same for the other packages as well)
> Index: xfsprogs-dev/build/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/Makefile 2009-02-24 19:39:37.259153164 +0100
> +++ xfsprogs-dev/build/Makefile 2009-02-24 19:39:58.817035065 +0100
> @@ -6,7 +6,7 @@ TOPDIR = ..
> include $(TOPDIR)/include/builddefs
>
> MANIFEST=src-manifest
> -SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
> +SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>
> LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
>
> Index: xfsprogs-dev/build/tar/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/tar/Makefile 2009-02-24 19:40:08.459152818 +0100
> +++ xfsprogs-dev/build/tar/Makefile 2009-02-24 19:40:13.721029934 +0100
> @@ -5,7 +5,7 @@
> TOPDIR = ../..
> include $(TOPDIR)/include/builddefs
>
> -BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> +BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
> LDIRT = *.gz
>
> default install install-dev install-lib:
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-03-22 20:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 20:21 tarballs generated by Makepkgs Christoph Hellwig
2009-02-24 18:42 ` Christoph Hellwig
2009-03-16 6:32 ` Christoph Hellwig
2009-03-22 19:22 ` Eric Sandeen [this message]
2009-03-23 15:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C68FE0.4030501@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox