From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	n2MKlBK6093753 for <xfs@oss.sgi.com>; Sun, 22 Mar 2009 15:47:32 -0500
Received: from mx2.redhat.com (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id A08EA13BC411
	for <xfs@oss.sgi.com>; Sun, 22 Mar 2009 13:46:33 -0700 (PDT)
Received: from mx2.redhat.com (mx2.redhat.com [66.187.237.31]) by cuda.sgi.com
	with ESMTP id 1P6DD3ncvMyFDAbr for <xfs@oss.sgi.com>;
	Sun, 22 Mar 2009 13:46:33 -0700 (PDT)
Message-ID: <49C68FE0.4030501@sandeen.net>
Date: Sun, 22 Mar 2009 14:22:08 -0500
From: Eric Sandeen <sandeen@sandeen.net>
MIME-Version: 1.0
Subject: Re: tarballs generated by Makepkgs
References: <20090215202125.GA18218@infradead.org>
	<20090224184252.GA28007@infradead.org>
In-Reply-To: <20090224184252.GA28007@infradead.org>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com

Christoph Hellwig wrote:
> On Sun, Feb 15, 2009 at 03:21:25PM -0500, Christoph Hellwig wrote:
>> currently Makepkgs generats the source tarball as
>> package-version.src.tar.gz, which is not what we used for recent
>> releases and not what most other open source packages do.  I'd like to
>> change it to package-version.tar.gz, but that currently collides with
>> the binary tar packages.
>>
>> Does anyone still need those binary tar packages?  If yes we should
>> rename them, too or otherwise just remove them.
> 
> This would be the easiest way, renaming the binary packages to
> xfsprogs-$ver.bin.tar.gz and the source to the expected
> xfsprogs-$ver.tar.gz.  Same patch would also go into xfsdump and dmapi.
> 

Yes, this looks good.  it always bugged me the way it was ;)

Missed this for review based on no [PATCH] ;)

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

(same for the other packages as well)

> Index: xfsprogs-dev/build/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/Makefile	2009-02-24 19:39:37.259153164 +0100
> +++ xfsprogs-dev/build/Makefile	2009-02-24 19:39:58.817035065 +0100
> @@ -6,7 +6,7 @@ TOPDIR = ..
>  include $(TOPDIR)/include/builddefs
>  
>  MANIFEST=src-manifest
> -SRCTAR=$(PKG_NAME)-$(PKG_VERSION).src.tar.gz
> +SRCTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  
>  LDIRT = *-manifest *.gz $(TOPDIR)/$(PKG_NAME)-*
>  
> Index: xfsprogs-dev/build/tar/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/build/tar/Makefile	2009-02-24 19:40:08.459152818 +0100
> +++ xfsprogs-dev/build/tar/Makefile	2009-02-24 19:40:13.721029934 +0100
> @@ -5,7 +5,7 @@
>  TOPDIR = ../..
>  include $(TOPDIR)/include/builddefs
>  
> -BINTAR=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> +BINTAR=$(PKG_NAME)-$(PKG_VERSION).bin.tar.gz
>  LDIRT = *.gz
>  
>  default install install-dev install-lib:
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs