From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests: skip dump tests if dump utils not found
Date: Sun, 19 Apr 2009 15:54:40 -0500 [thread overview]
Message-ID: <49EB8F90.20705@sandeen.net> (raw)
I was running xfstests on a NAS box which had no xfsdump,
and any tests which required xfsdump were failing in not-so-nice
ways:
> xfsdump not found
038 [failed, exit status 1] - output mismatch (see 038.out.bad)
I think using _notrun is a lot better:
038 [not run] xfsdump not found
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/common.dump b/common.dump
index 6d2f120..fcc4945 100644
--- a/common.dump
+++ b/common.dump
@@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then
[ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug"
fi
-[ "$XFSDUMP_PROG" = "" ] && _fatal "xfsdump not found"
-[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found"
-[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found"
+[ "$XFSDUMP_PROG" = "" ] && _notrun "xfsdump not found"
+[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found"
+[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found"
# status returned for not run tests
NOTRUNSTS=2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2009-04-19 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 20:54 Eric Sandeen [this message]
2009-04-19 21:38 ` [PATCH] xfstests: skip dump tests if dump utils not found Christoph Hellwig
2009-04-19 21:43 ` Josef 'Jeff' Sipek
2009-04-19 21:50 ` [PATCH] xfstests: skip fsr tests if xfs_fsr " Eric Sandeen
2009-04-19 22:14 ` Felix Blyakher
2009-04-21 14:14 ` Christoph Hellwig
2009-04-19 22:13 ` [PATCH] xfstests: skip dump tests if dump " Felix Blyakher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EB8F90.20705@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox