[PATCH] xfstests: skip dump tests if dump utils not found

[PATCH] xfstests: skip dump tests if dump utils not found

[Eric Sandeen]

I was running xfstests on a NAS box which had no xfsdump,
and any tests which required xfsdump were failing in not-so-nice
ways:

> xfsdump not found
038      [failed, exit status 1] - output mismatch (see 038.out.bad)

I think using _notrun is a lot better:

038      [not run] xfsdump not found

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/common.dump b/common.dump
index 6d2f120..fcc4945 100644
--- a/common.dump
+++ b/common.dump
@@ -23,9 +23,9 @@ if [ -n "$DEBUGDUMP" ]; then
 	[ -x $here/xfsinvutil ] && echo "Using xfstests' xfsinvutil for debug"
 fi
 
-[ "$XFSDUMP_PROG" = "" ]    && _fatal "xfsdump not found"
-[ "$XFSRESTORE_PROG" = "" ] && _fatal "xfsrestore not found"
-[ "$XFSINVUTIL_PROG" = "" ] && _fatal "xfsinvutil not found"
+[ "$XFSDUMP_PROG" = "" ]    && _notrun "xfsdump not found"
+[ "$XFSRESTORE_PROG" = "" ] && _notrun "xfsrestore not found"
+[ "$XFSINVUTIL_PROG" = "" ] && _notrun "xfsinvutil not found"
 
 # status returned for not run tests
 NOTRUNSTS=2


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip dump tests if dump utils not found

[Christoph Hellwig]

On Sun, Apr 19, 2009 at 03:54:40PM -0500, Eric Sandeen wrote:
> I was running xfstests on a NAS box which had no xfsdump,
> and any tests which required xfsdump were failing in not-so-nice
> ways:
> 
> > xfsdump not found
> 038      [failed, exit status 1] - output mismatch (see 038.out.bad)
> 
> I think using _notrun is a lot better:
> 
> 038      [not run] xfsdump not found
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Looks good.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip dump tests if dump utils not found

[Josef 'Jeff' Sipek]

On Sun, Apr 19, 2009 at 03:54:40PM -0500, Eric Sandeen wrote:
> I was running xfstests on a NAS box which had no xfsdump,
> and any tests which required xfsdump were failing in not-so-nice
> ways:
> 
> > xfsdump not found
> 038      [failed, exit status 1] - output mismatch (see 038.out.bad)
> 
> I think using _notrun is a lot better:
> 
> 038      [not run] xfsdump not found
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Sounds good.

Josef 'Jeff' Sipek.

-- 
Bad pun of the week: The formula 1 control computer suffered from a race
condition

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH] xfstests: skip fsr tests if xfs_fsr utils not found

[Eric Sandeen]

Similar to the xfsdump-related patch; gracefully fail
if no xfs_fsr is found.

I'll probably send another for the acl & attr userspace,
it's actually not always installed on minimal boxes.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/042 b/042
index 7c2bcac..6628040 100755
--- a/042
+++ b/042
@@ -37,6 +37,8 @@ _supported_os IRIX Linux
 
 _require_scratch
 
+[ "$XFS_FSR_PROG" = "" ] && _notrun "xfs_fsr not found"
+
 _cull_files()
 {
     perl -e "\$manifest=\"$tmp.manifest\";" -e '
diff --git a/111 b/111
index 060c0bc..3ce4ee1 100755
--- a/111
+++ b/111
@@ -27,6 +27,8 @@ _supported_fs xfs
 _supported_os Linux
 _require_scratch
 
+[ "$XFS_FSR_PROG" = "" ] && _notrun "xfs_fsr not found"
+
 # real QA test starts here
 umount $SCRATCH_DEV 2>/dev/null
 MKFS_OPTIONS="-bsize=4096"


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip fsr tests if xfs_fsr utils not found

[Felix Blyakher]

On Apr 19, 2009, at 4:50 PM, Eric Sandeen wrote:

> Similar to the xfsdump-related patch; gracefully fail
> if no xfs_fsr is found.
>
> I'll probably send another for the acl & attr userspace,
> it's actually not always installed on minimal boxes.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Looks good.

Felix

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip fsr tests if xfs_fsr utils not found

[Christoph Hellwig]

On Sun, Apr 19, 2009 at 04:50:59PM -0500, Eric Sandeen wrote:
> Similar to the xfsdump-related patch; gracefully fail
> if no xfs_fsr is found.
> 
> I'll probably send another for the acl & attr userspace,
> it's actually not always installed on minimal boxes.

Looks good, too.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: skip dump tests if dump utils not found

[Felix Blyakher]

On Apr 19, 2009, at 3:54 PM, Eric Sandeen wrote:

> I was running xfstests on a NAS box which had no xfsdump,
> and any tests which required xfsdump were failing in not-so-nice
> ways:
>
>> xfsdump not found
> 038      [failed, exit status 1] - output mismatch (see 038.out.bad)
>
> I think using _notrun is a lot better:
>
> 038      [not run] xfsdump not found
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Seems good.

Felix

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs