[PATCH, RFC] put xfs build features into the stats file

[PATCH, RFC] put xfs build features into the stats file

[Eric Sandeen]

Running xfstests on an xfs build w/o xattrs enabled, I realized
there's no reliable way to see if the running xfs has various
features other than debug (which is shown in /proc/fs/xfs/stat)

What do folks think of adding the BUILD_OPTIONS to this file
as well?

# cat /proc/fs/xfs/stat
extent_alloc 0 0 0 0
...
xpc 0 0 0
debug 0
features security attributes, large block numbers, no debug 

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

Index: linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_stats.c
+++ linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
@@ -89,6 +89,8 @@ xfs_read_xfsstats(
 		0);
 #endif
 
+	len += sprintf(buffer + len, "features " XFS_BUILD_OPTIONS "\n");
+
 	if (offset >= len) {
 		*start = buffer;
 		*eof = 1;

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH, RFC] put xfs build features into the stats file

[Nathan Scott]

Separate file?  That line uses a comma separator ... differs to
every other line in that stats file, painful for parsers.  And
no risk of breaking anything if its a separate file.

cheers.

----- "Eric Sandeen" <sandeen@sandeen.net> wrote:

> Running xfstests on an xfs build w/o xattrs enabled, I realized
> there's no reliable way to see if the running xfs has various
> features other than debug (which is shown in /proc/fs/xfs/stat)
> 
> What do folks think of adding the BUILD_OPTIONS to this file
> as well?
> 
> # cat /proc/fs/xfs/stat
> extent_alloc 0 0 0 0
> ...
> xpc 0 0 0
> debug 0
> features security attributes, large block numbers, no debug 
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_stats.c
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_stats.c
> @@ -89,6 +89,8 @@ xfs_read_xfsstats(
>  		0);
>  #endif
>  
> +	len += sprintf(buffer + len, "features " XFS_BUILD_OPTIONS "\n");
> +
>  	if (offset >= len) {
>  		*start = buffer;
>  		*eof = 1;
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH, RFC] put xfs build features into the stats file

[Eric Sandeen]

Nathan Scott wrote:
> Separate file?  That line uses a comma separator ... differs to
> every other line in that stats file, painful for parsers.  And
> no risk of breaking anything if its a separate file.
> 
> cheers.

Hm good point.  Might do; not that big a deal, just wanted to be able to
gracefully skip acl/attr xfstests if the xfs build didn't support it :)

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH, RFC] put xfs build features into the stats file

[Christoph Hellwig]

On Sun, Apr 19, 2009 at 09:34:24PM -0500, Eric Sandeen wrote:
> Running xfstests on an xfs build w/o xattrs enabled

How did you disable xattrs?

Should probably be a separate file, though.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH, RFC] put xfs build features into the stats file

[Eric Sandeen]

Christoph Hellwig wrote:
> On Sun, Apr 19, 2009 at 09:34:24PM -0500, Eric Sandeen wrote:
>> Running xfstests on an xfs build w/o xattrs enabled
> 
> How did you disable xattrs?

Oh sorry, meant acls, with CONFIG_XFS_POSIX_ACL

> Should probably be a separate file, though.

Yeah, you're right, I'll go study up on sysfs. :)

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs