From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: enforce lazy-count=0 in log tests 018, 081, 082
Date: Thu, 23 Apr 2009 12:24:31 -0500 [thread overview]
Message-ID: <49F0A44F.9040603@sandeen.net> (raw)
In-Reply-To: <20090423171151.GB11391@infradead.org>
Christoph Hellwig wrote:
> On Tue, Apr 21, 2009 at 03:13:30PM -0500, Eric Sandeen wrote:
>> I was experimenting w/ default lazy-count=1, and it broke a few tests.
>> Seems simplest to enforce lazy-count=0 in the common.log routines
>> for now, and fix up the output? (vs. updating all the expected
>> output for these tests...)
>
> Didn't you just send a patch to make lazy-count=1 the default? :)
>
> I'd rather see either a filter dealing with both variants or make
> sure we always test the newer and more important case (lazy-count=1)
> here.
I don't think that a filter will be possible, it pretty fundamentally
changes log traffic doesn't it? I could make 2 expected outputs,
perhaps, one for each... I'll double check though.
I just made it forced to 0 because I don't think these tests are really
testing anything relevant to whether or not lazy-count is enabled...
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-04-23 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 20:13 [PATCH] xfstests: enforce lazy-count=0 in log tests 018, 081, 082 Eric Sandeen
2009-04-22 19:12 ` Josef 'Jeff' Sipek
2009-04-22 19:22 ` Eric Sandeen
2009-04-23 17:11 ` Christoph Hellwig
2009-04-23 17:24 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F0A44F.9040603@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox