Re: [PATCH V2] xfstests: add aio-dio-test suite

Eric Sandeen
2009-05-10T18:21:23Z

Christoph Hellwig wrote:
> On Fri, May 08, 2009 at 11:48:17PM -0500, Eric Sandeen wrote:
>> Pull in the aio-dio-regress test suite from
>> http://git.kernel.org/?p=linux/kernel/git/zab/aio-dio-regress.git
>>
>> Changed from last time to break out into individual tests,
>> and move it under src/aio-dio-regress
>>
>> Also flagged a few as part of the "quick" group.
>
> The xfsqa integration looks good to me. Might be worth to mention
> what test each test cases runs in the top of file comments instead
> of just the aio+dio testsuite.

good point, I'll lift comments from the tests themselves into the scripts.

> Also what about keeping a file named SOURCE or similar in
> src/aio-dio-regress to tell exactly where we got this version
> from (repository + commit) so that we know what to diff against.

ok, sure.

I'll ask jeff & zach to put some proper licensing on the c files, and do
the same for my new scripts as well.

-Eric