From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: update max log size
Date: Mon, 11 May 2009 11:25:23 -0500 [thread overview]
Message-ID: <4A085173.5040208@sandeen.net> (raw)
In-Reply-To: <20090511160609.GA18278@infradead.org>
Christoph Hellwig wrote:
> Commit a6634fba3dec4a92f0a2c4e30c80b634c0576ad5 in xfsprogs increased the
> maximum log size supported by mkfs. Merged back the changes to xfs_fs.h
> so the growfs enforced the same limit and the headers are in sync.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Ok, looks like kernelspace only cares about this during
xfs_growfs_log_private(), and that's not actually implemented yet,
right? So no worries about kernel<->userspace version correlation I think.
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> Index: xfs/fs/xfs/xfs_fs.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_fs.h 2009-02-08 21:51:06.576943974 +0100
> +++ xfs/fs/xfs/xfs_fs.h 2009-05-10 21:33:30.970822643 +0200
> @@ -239,10 +239,13 @@ typedef struct xfs_fsop_resblks {
> * Minimum and maximum sizes need for growth checks
> */
> #define XFS_MIN_AG_BLOCKS 64
> -#define XFS_MIN_LOG_BLOCKS 512
> -#define XFS_MAX_LOG_BLOCKS (64 * 1024)
> -#define XFS_MIN_LOG_BYTES (256 * 1024)
> -#define XFS_MAX_LOG_BYTES (128 * 1024 * 1024)
> +#define XFS_MIN_LOG_BLOCKS 512ULL
> +#define XFS_MAX_LOG_BLOCKS (1024 * 1024ULL)
> +#define XFS_MIN_LOG_BYTES (10 * 1024 * 1024ULL)
> +
> +/* keep the maximum size under 2^31 by a small amount */
> +#define XFS_MAX_LOG_BYTES \
> + ((2 * 1024 * 1024 * 1024ULL) - XFS_MIN_LOG_BYTES)
>
> /*
> * Structures for XFS_IOC_FSGROWFSDATA, XFS_IOC_FSGROWFSLOG & XFS_IOC_FSGROWFSRT
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-11 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 16:06 [PATCH] xfs: update max log size Christoph Hellwig
2009-05-11 16:25 ` Eric Sandeen [this message]
2009-05-11 16:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A085173.5040208@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox