From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota
Date: Sat, 16 May 2009 17:01:51 -0500 [thread overview]
Message-ID: <4A0F37CF.4030709@sandeen.net> (raw)
In-Reply-To: <20090516203413.GB28186@infradead.org>
Christoph Hellwig wrote:
> On Fri, May 15, 2009 at 08:31:40PM -0500, Eric Sandeen wrote:
>> It looks like libxcmd wasn't ever being built with -DENABLE_READLINE
>> even when it was asked for by configure --enable-readline=yes
>> so xfs_io & xfs_quota didn't get the functionality.
>>
>> This seems to fix it up for me (fixes editline too while we're
>> at it).
>
> I've also been wondering for quite some while why xfs_io didn't have
> working readline support.
>
> This patch makes it work for me and looks good:
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> (btw, any reason we don't enable readline support by default if
> we find the headers installed?)
>
I dunno... Nathan, any idea? Maybe some git-digging is in order.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-16 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 1:31 [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota Eric Sandeen
2009-05-16 20:34 ` Christoph Hellwig
2009-05-16 22:01 ` Eric Sandeen [this message]
2009-05-16 22:14 ` Eric Sandeen
2009-05-17 0:21 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0F37CF.4030709@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox