From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n4GM1jLi143970 for ; Sat, 16 May 2009 17:01:45 -0500 Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 31758FBF585 for ; Sat, 16 May 2009 15:06:51 -0700 (PDT) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id m8Xxj6yDXawpnS8l for ; Sat, 16 May 2009 15:06:51 -0700 (PDT) Message-ID: <4A0F37CF.4030709@sandeen.net> Date: Sat, 16 May 2009 17:01:51 -0500 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] xfsprogs: fix readline/editline for xfs_io and xfs_quota References: <4A0E177C.7070902@sandeen.net> <20090516203413.GB28186@infradead.org> In-Reply-To: <20090516203413.GB28186@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs-oss Christoph Hellwig wrote: > On Fri, May 15, 2009 at 08:31:40PM -0500, Eric Sandeen wrote: >> It looks like libxcmd wasn't ever being built with -DENABLE_READLINE >> even when it was asked for by configure --enable-readline=yes >> so xfs_io & xfs_quota didn't get the functionality. >> >> This seems to fix it up for me (fixes editline too while we're >> at it). > > I've also been wondering for quite some while why xfs_io didn't have > working readline support. > > This patch makes it work for me and looks good: > > > Reviewed-by: Christoph Hellwig > > (btw, any reason we don't enable readline support by default if > we find the headers installed?) > I dunno... Nathan, any idea? Maybe some git-digging is in order. -Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs