From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io
Date: Sat, 16 May 2009 17:08:43 -0500 [thread overview]
Message-ID: <4A0F396B.8010504@sandeen.net> (raw)
In-Reply-To: <20090516204025.GC28186@infradead.org>
Christoph Hellwig wrote:
> On Fri, May 15, 2009 at 05:11:24PM -0500, Eric Sandeen wrote:
>> Instead of above does this work better?
>>
>> (just change AC_TRY_COMPILE to AC_TRY_LINK)
>
> Yes, that correctly detects fallocate as not present for me and
> thus gives a working fallocate.
>
>> AC_DEFUN([AC_HAVE_FALLOCATE],
>> [ AC_MSG_CHECKING([for fallocate])
>> AC_TRY_LINK([
>> #include <linux/falloc.h>
>> ], [
>> fallocate(0, 0, 0, 0);
>
> Why do you nee to include <linux/falloc.h> here anyway? You don't use
> any of the constants, and the fallocate libc call must be in another
> headers, so it obviously compiles even without a defintion for it.
Well, the actual patch includes it for FALLOC_FL_KEEP_SIZE so it'd be
better to detect it at config time and if not there fail?
Or we could #ifndef and have a local define ...
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-05-16 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 0:30 [PATCH] xfsprogs: add fallocate command to xfs_io Eric Sandeen
2009-05-15 17:13 ` Christoph Hellwig
2009-05-15 17:27 ` Christoph Hellwig
2009-05-15 18:50 ` Eric Sandeen
2009-05-15 22:11 ` Eric Sandeen
2009-05-16 20:40 ` Christoph Hellwig
2009-05-16 22:08 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0F396B.8010504@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox