From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: kill xfs_qmops
Date: Wed, 27 May 2009 15:06:25 -0500 [thread overview]
Message-ID: <4A1D9D41.7040107@sandeen.net> (raw)
In-Reply-To: <20090527095616.GA19069@infradead.org>
Christoph Hellwig wrote:
...
> never, but that's a bug because the loop should now start at 0. Looks
> like out quota testing in xfsqa still isn't that good or the first
> inode is always already attached in normal operation (probably the latter).
>
> Updated patch below:
>
>
> Subject: xfs: kill xfs_qmops
> From: Christoph Hellwig <hch@lst.de>
>
> Kill the quota ops function vector and replace it with direct calls or
> stubs in the CONFIG_XFS_QUOTA=n case.
>
> Make sure we check XFS_IS_QUOTA_RUNNING in the right spots. We can remove
> the number of those checks because the XFS_TRANS_DQ_DIRTY flag can't be set
> otherwise.
>
> This brings us back closer to the way this code worked in IRIX and earlier
> Linux versions, but we keep a lot of the more useful factoring of common
> code.
>
> Eventually we should also kill xfs_qm_bhv.c, but that's left for a later
> patch.
>
> Reduces the size of the source code by about 250 lines and the size of
> XFS module by about 1.5 kilobytes with quotas enabled:
>
> text data bss dec hex filename
> 615957 2960 3848 622765 980ad fs/xfs/xfs.o
> 617231 3152 3848 624231 98667 fs/xfs/xfs.o.old
>
>
> Fallout:
>
> - xfs_qm_dqattach is split into xfs_qm_dqattach_locked which expects
> the inode locked and xfs_qm_dqattach which does the locking around it,
> thus removing XFS_QMOPT_ILOCKED.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
Looks better to me now, thanks. Though worrisome that quota doesn't
seem well-tested in xfsqa, as you said... but as far as I can tell seems
ok now. Have arekm test it a bit too ;)
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-05-27 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 14:37 [PATCH] xfs: kill xfs_qmops Christoph Hellwig
2009-03-16 7:55 ` Christoph Hellwig
2009-03-29 7:44 ` Christoph Hellwig
2009-05-26 17:34 ` Eric Sandeen
2009-05-27 9:56 ` Christoph Hellwig
2009-05-27 20:06 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1D9D41.7040107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox