From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: [PATCH 1/9 V2] Use xfs.h rather than libxfs.h
Date: Thu, 28 May 2009 11:16:30 -0500 [thread overview]
Message-ID: <4A1EB8DE.40108@sandeen.net> (raw)
In-Reply-To: <20090528095657.GA651@infradead.org>
Use xfs/xfs.h when possible rather than xfs/libxfs.h,
now that libxfs.h isn't part of a normal xfsprogs-devel
install.
v2: take the MAXNAMELEN changes out of the mix and
remove redefinitions of ioctls easily available from xfs.h
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/aclocal.m4 b/aclocal.m4
index 52f1c7d..6cc5dce 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -405,6 +405,17 @@ AC_DEFUN([AC_PACKAGE_NEED_UUIDCOMPARE],
AC_SUBST(libuuid)
])
+AC_DEFUN([AC_PACKAGE_NEED_XFS_XFS_H],
+ [ AC_CHECK_HEADERS([xfs/xfs.h])
+ if test "$ac_cv_header_xfs_xfs_h" != "yes"; then
+ echo
+ echo 'FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.'
+ echo 'Install or upgrade the XFS development package.'
+ echo 'Alternatively, run "make install-dev" from the xfsprogs source.'
+ exit 1
+ fi
+ ])
+
AC_DEFUN([AC_PACKAGE_NEED_XFS_LIBXFS_H],
[ AC_CHECK_HEADERS([xfs/libxfs.h])
if test "$ac_cv_header_xfs_libxfs_h" != "yes"; then
@@ -500,8 +511,8 @@ AC_DEFUN([AC_PACKAGE_NEED_IRIX_LIBHANDLE],
])
AC_DEFUN([AC_PACKAGE_NEED_XFSCTL_MACRO],
- [ AC_MSG_CHECKING([xfsctl from xfs/libxfs.h])
- AC_TRY_LINK([#include <xfs/libxfs.h>], [ int x = xfsctl(0, 0, 0, 0); ],
+ [ AC_MSG_CHECKING([xfsctl from xfs/xfs.h])
+ AC_TRY_LINK([#include <xfs/xfs.h>], [ int x = xfsctl(0, 0, 0, 0); ],
[ echo ok ],
[ echo
echo 'FATAL ERROR: cannot find required macros in the XFS headers.'
diff --git a/configure.in b/configure.in
index 32a2496..f087454 100644
--- a/configure.in
+++ b/configure.in
@@ -44,6 +44,7 @@ in
;;
*)
AC_MULTILIB($enable_lib64)
+ AC_PACKAGE_NEED_XFS_XFS_H
AC_PACKAGE_NEED_XFS_LIBXFS_H
AC_PACKAGE_NEED_XFS_XQM_H
AC_PACKAGE_NEED_XFSCTL_MACRO
diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
index cafd959..2c8d694 100644
--- a/m4/package_xfslibs.m4
+++ b/m4/package_xfslibs.m4
@@ -1,3 +1,13 @@
+AC_DEFUN([AC_PACKAGE_NEED_XFS_XFS_H],
+ [ AC_CHECK_HEADERS([xfs/xfs.h])
+ if test "$ac_cv_header_xfs_xfs_h" != "yes"; then
+ echo
+ echo 'FATAL ERROR: cannot find a valid <xfs/xfs.h> header file.'
+ echo 'Run "make install-qa" from the xfsprogs source.'
+ exit 1
+ fi
+ ])
+
AC_DEFUN([AC_PACKAGE_NEED_XFS_LIBXFS_H],
[ AC_CHECK_HEADERS([xfs/libxfs.h])
if test "$ac_cv_header_xfs_libxfs_h" != "yes"; then
diff --git a/src/global.h b/src/global.h
index 158c1fa..61862f6 100644
--- a/src/global.h
+++ b/src/global.h
@@ -26,6 +26,10 @@
#include <../../xfsprogs/include/irix.h>
#endif
+#ifdef HAVE_XFS_XFS_H
+#include <xfs/xfs.h>
+#endif
+
#ifdef HAVE_XFS_LIBXFS_H
#include <xfs/libxfs.h>
#endif
diff --git a/src/godown.c b/src/godown.c
index 4105aee..07b6980 100644
--- a/src/godown.c
+++ b/src/godown.c
@@ -18,20 +18,6 @@
#include "global.h"
-/* These should be in libxfs.h */
-#ifndef XFS_IOC_GOINGDOWN
-#define XFS_IOC_GOINGDOWN _IOR ('X', 125, __uint32_t)
-#endif
-#ifndef XFS_FSOP_GOING_FLAGS_DEFAULT
-#define XFS_FSOP_GOING_FLAGS_DEFAULT 0x0 /* going down */
-#endif
-#ifndef XFS_FSOP_GOING_FLAGS_LOGFLUSH
-#define XFS_FSOP_GOING_FLAGS_LOGFLUSH 0x1 /* flush log */
-#endif
-#ifndef XFS_FSOP_GOING_FLAGS_NOLOGFLUSH
-#define XFS_FSOP_GOING_FLAGS_NOLOGFLUSH 0x2 /* don't flush log */
-#endif
-
static char *xprogname;
diff --git a/src/iopat.c b/src/iopat.c
index 1e7d61b..c06071f 100644
--- a/src/iopat.c
+++ b/src/iopat.c
@@ -18,7 +18,7 @@
#include <fcntl.h>
#include <sys/ioctl.h>
-#include <xfs/libxfs.h>
+#include <xfs/xfs.h>
struct xfs_flock64 f;
int main(int argc, char **argv)
diff --git a/src/t_immutable.c b/src/t_immutable.c
index 667355b..07a36cd 100644
--- a/src/t_immutable.c
+++ b/src/t_immutable.c
@@ -38,7 +38,7 @@
#include <libgen.h>
#include <sys/acl.h>
#include <attr/xattr.h>
-#include <xfs/libxfs.h>
+#include <xfs/xfs.h>
#include <xfs/handle.h>
#include <xfs/jdm.h>
@@ -47,6 +47,10 @@
#define EXT2_APPEND_FL 0x00000020
#define EXT2_IOC_SETFLAGS _IOW('f', 2, long)
+#ifndef XFS_SUPER_MAGIC
+#define XFS_SUPER_MAGIC 0x58465342
+#endif
+
extern const char *__progname;
static int fsetflag(const char *path, int fd, int on, int immutable)
diff --git a/src/unwritten_mmap.c b/src/unwritten_mmap.c
index 5e63486..aec6a69 100644
--- a/src/unwritten_mmap.c
+++ b/src/unwritten_mmap.c
@@ -2,7 +2,7 @@
#include <stdlib.h>
#include <unistd.h>
#include <fcntl.h>
-#include <xfs/libxfs.h>
+#include <xfs/xfs.h>
#include <sys/mman.h>
/*
diff --git a/src/xfsctl.c b/src/xfsctl.c
index f8afb16..8fa3348 100644
--- a/src/xfsctl.c
+++ b/src/xfsctl.c
@@ -16,7 +16,7 @@
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
-#include <xfs/libxfs.h>
+#include <xfs/xfs.h>
#include <xfs/jdm.h>
/* simple test program to try out a bunch of xfsctls:
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2009-05-28 16:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 18:53 [PATCH 0/9] xfstests: more generic fs work Eric Sandeen
2009-05-27 18:53 ` [PATCH 1/9] Use xfs.h rather than libxfs.h Eric Sandeen
2009-05-28 9:56 ` Christoph Hellwig
2009-05-28 15:46 ` [PATCH 0.5/9] Replace MAXNAMELEN with NAME_MAX + 1 Eric Sandeen
2009-05-28 15:48 ` Christoph Hellwig
2009-05-28 16:16 ` Eric Sandeen [this message]
2009-05-28 16:22 ` [PATCH 1/9 V2] Use xfs.h rather than libxfs.h Christoph Hellwig
2009-05-27 18:53 ` [PATCH 2/9] Make libxfs.h optional Eric Sandeen
2009-05-28 9:57 ` Christoph Hellwig
2009-05-28 14:59 ` Eric Sandeen
2009-05-28 15:35 ` Christoph Hellwig
2009-05-28 16:15 ` Eric Sandeen
2009-05-27 18:53 ` [PATCH 3/9] Support "generic" filesystem type Eric Sandeen
2009-05-28 9:58 ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 4/9] 069: make scratch mkfs quiet Eric Sandeen
2009-05-28 9:58 ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 5/9] Set up testdir for generic filesystems Eric Sandeen
2009-05-28 9:59 ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 6/9] Detect FS type to test based on TEST_DEV Eric Sandeen
2009-05-28 9:59 ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 7/9] Set default extN mount options Eric Sandeen
2009-05-28 9:11 ` Michael Monnerie
2009-05-28 10:02 ` Christoph Hellwig
2009-05-28 10:35 ` Michael Monnerie
2009-05-28 14:56 ` Eric Sandeen
2009-05-29 6:37 ` Michael Monnerie
2009-05-28 10:01 ` Christoph Hellwig
2009-05-28 14:57 ` Eric Sandeen
2009-05-27 18:53 ` [PATCH 8/9] Enable generic filesystems to be fsck'd Eric Sandeen
2009-05-28 12:51 ` Christoph Hellwig
2009-06-02 12:38 ` Christoph Hellwig
2009-06-02 15:10 ` Eric Sandeen
2009-06-02 17:25 ` Christoph Hellwig
2009-05-27 18:53 ` [PATCH 9/9] Report which tests did get run Eric Sandeen
2009-05-28 12:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1EB8DE.40108@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox